Implement parser for Netware-style FTP LIST response listing.

Implement parser for Netware-style FTP LIST response listing.

TEST=Covered by net_unittests.
BUG=25520
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33978

[Paweł Hajdan Jr., 2009-12-04 16:40:01]

I encountered at least two such servers in the field.

The Mozilla parser handles them as "ls -l", but for our design I think it's
clearer to make a new parser instead. The only similar thing seems to be date.

I don't really know the meaning of the permission string. But it's very useful
to recognize the format.

I also decided to drop the "gesamt" thing. Should be clearer now, with no loss
of accuracy.

Please let me know and ask if anything is unclear. This really helps me
improving the code.

[Paweł Hajdan Jr., 2009-12-07 15:10:51]

ping!

[eroman, 2009-12-07 19:15:54]

oops, forgot to hit Publish button!

LGTM

http://codereview.chromium.org/465059/diff/1/10
File net/ftp/ftp_directory_listing_parser_netware.cc (right):

http://codereview.chromium.org/465059/diff/1/10#newcode65
net/ftp/ftp_directory_listing_parser_netware.cc:65: // support the older format
here for simplicity.
is this a compat issue?

http://codereview.chromium.org/465059/diff/1/10#newcode97
net/ftp/ftp_directory_listing_parser_netware.cc:97: FtpDirectoryListingEntry
entry = entries_.front();
Might want to DCHECK(EntryAvailable())

http://codereview.chromium.org/465059/diff/1/12
File net/ftp/ftp_directory_listing_parser_netware_unittest.cc (right):

http://codereview.chromium.org/465059/diff/1/12#newcode27
net/ftp/ftp_directory_listing_parser_netware_unittest.cc:27:
SCOPED_TRACE(StringPrintf("Test[%" PRIuS "]: %s", i, good_cases[i].input));
yuck, PRIus :(

[wtc, 2009-12-08 01:50:35]

http://codereview.chromium.org/465059/diff/1/12
File net/ftp/ftp_directory_listing_parser_netware_unittest.cc (right):

http://codereview.chromium.org/465059/diff/1/12#newcode26
net/ftp/ftp_directory_listing_parser_netware_unittest.cc:26: for (size_t i = 0;
i < arraysize(good_cases); i++) {
You can declare i as unsigned int instead of size_t so
that you can print i with the %u format.

[Peter Kasting, 2009-12-08 01:57:13]

http://codereview.chromium.org/465059/diff/1/12
File net/ftp/ftp_directory_listing_parser_netware_unittest.cc (right):

http://codereview.chromium.org/465059/diff/1/12#newcode26
net/ftp/ftp_directory_listing_parser_netware_unittest.cc:26: for (size_t i = 0;
i < arraysize(good_cases); i++) {
On 2009/12/08 01:50:35, wtc wrote:
> You can declare i as unsigned int instead of size_t so
> that you can print i with the %u format.

Google style guide forbids this.  size_t is the correct type to use here.