Issue 465048: net: Ignore the magic number sniffer if it determines an application/octet-st...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465048: net: Ignore the magic number sniffer if it determines an application/octet-st... (Closed)

Created:
11 years ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
jamesr

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

abarth fixed this in a separate CL. net: Ignore the magic number sniffer if it determines an application/octet-stream resource is text/plain. BUG=29354 TEST=See bug.

Patch Set 1 #

Total comments: 1

Patch Set 2 : with additional comment #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	net/base/mime_sniffer.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
	M	net/base/mime_sniffer_unittest.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jamesr

11 years ago (2009-12-04 01:33:26 UTC) #1

http://codereview.chromium.org/465048/diff/1/2
File net/base/mime_sniffer.cc (right):

http://codereview.chromium.org/465048/diff/1/2#newcode583
net/base/mime_sniffer.cc:583: if (type_hint == "application/octet-stream" &&
"text/plain" == *result)
Please include some sort of explanation for this (maybe a link to the bug).

Expand Messages | Collapse Messages