Issue 465043: Change "OTHER" to "MISSING". All the expectations that used to be...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465043: Change "OTHER" to "MISSING". All the expectations that used to be... (Closed)

Created:
11 years ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
Julie Parent

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Change "OTHER" to "MISSING". All the expectations that used to be classified as OTHER are now otherwise classified except for missing expectations. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33763

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	webkit/tools/layout_tests/dashboards/dashboard_base.js	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	webkit/tools/layout_tests/flakiness_dashboard.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Julie Parent

11 years ago (2009-12-04 00:53:12 UTC) #2

LGTM

http://codereview.chromium.org/465043/diff/1/3
File webkit/tools/layout_tests/dashboards/dashboard_base.js (right):

http://codereview.chromium.org/465043/diff/1/3#newcode45
webkit/tools/layout_tests/dashboards/dashboard_base.js:45: 'O': 'MISSING',
Maybe add a comment here about why O stands for Missing?

Expand Messages | Collapse Messages