net/net.gyp - Issue 465035: Split FTP LIST parsing code into individual files for each listing style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/net.gyp

Issue 465035: Split FTP LIST parsing code into individual files for each listing style. (Closed)

Patch Set: fix Created 11 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/net.gyp

diff --git a/net/net.gyp b/net/net.gyp

index cfc228644f9a862d7e265d7a2cfb5c2347d35440..51e3cb7dd9f57d46cd97ffd595add6c4e5db25b2 100644

--- a/net/net.gyp

+++ b/net/net.gyp

@@ -294,8 +294,14 @@

'ftp/ftp_ctrl_response_buffer.h',

'ftp/ftp_directory_listing_buffer.cc',

'ftp/ftp_directory_listing_buffer.h',

- 'ftp/ftp_directory_listing_parsers.cc',

- 'ftp/ftp_directory_listing_parsers.h',

+ 'ftp/ftp_directory_listing_parser.cc',

+ 'ftp/ftp_directory_listing_parser.h',

+ 'ftp/ftp_directory_listing_parser_ls.cc',

+ 'ftp/ftp_directory_listing_parser_ls.h',

+ 'ftp/ftp_directory_listing_parser_vms.cc',

+ 'ftp/ftp_directory_listing_parser_vms.h',

+ 'ftp/ftp_directory_listing_parser_windows.cc',

+ 'ftp/ftp_directory_listing_parser_windows.h',

'ftp/ftp_network_layer.cc',

'ftp/ftp_network_layer.h',

'ftp/ftp_network_session.h',

@@ -607,7 +613,9 @@

'ftp/ftp_auth_cache_unittest.cc',

'ftp/ftp_ctrl_response_buffer_unittest.cc',

'ftp/ftp_directory_listing_buffer_unittest.cc',

- 'ftp/ftp_directory_listing_parsers_unittest.cc',

+ 'ftp/ftp_directory_listing_parser_ls_unittest.cc',

+ 'ftp/ftp_directory_listing_parser_vms_unittest.cc',

+ 'ftp/ftp_directory_listing_parser_windows_unittest.cc',

'ftp/ftp_network_transaction_unittest.cc',

'ftp/ftp_util_unittest.cc',

'http/des_unittest.cc',

« no previous file with comments | « net/ftp/ftp_util.cc ('k') | webkit/glue/ftp_directory_listing_response_delegate.cc » ('j') | no next file with comments »