Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 465033002: InspectorOverlay should call layout in the normal way (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
esprehn, pfeldman
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

InspectorOverlay should call layout in the normal way The InspectorOverlay does a bunch of manual poking and prodding of the layout state machine. Instead, InspectorOverlay should just use updateLayoutAndStyleForPainting like the regular engine does. R=esprehn@chromium.org, pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M Source/core/inspector/InspectorOverlay.cpp View 2 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-12 21:29:10 UTC) #1
esprehn
lgtm
6 years, 4 months ago (2014-08-12 21:44:14 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-12 21:51:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/465033002/1
6 years, 4 months ago (2014-08-12 21:53:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-12 22:25:45 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 22:55:02 UTC) #6
Message was sent while issue was closed.
Change committed as 180114

Powered by Google App Engine
This is Rietveld 408576698