[MediaGalleries] Context menu for Mac media galleries dialog.

chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm

Index: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm b/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
index edc13a173cba4cfdad52f307321bd5b057e81d12..e83f79e133e03c0c395c5aeb23bfc6d4628db05b 100644
--- a/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
@@ -4,6 +4,7 @@
 
 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h"
 
+#include "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/ui/chrome_style.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h"
@@ -14,9 +15,12 @@
 #include "content/public/browser/web_contents.h"
 #include "grit/generated_resources.h"
 #import "ui/base/cocoa/flipped_view.h"
+#import "ui/base/cocoa/menu_controller.h"
+#import "ui/base/models/menu_model.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
+// Controller for UI events on items in the media galleries dialog.
 @interface MediaGalleriesCocoaController : NSObject {
  @private
   MediaGalleriesDialogCocoa* dialog_;
@@ -50,6 +54,40 @@
 
 @end
 
+@interface MediaGalleriesCheckbox : NSButton {
+ @private
+  MediaGalleriesDialogCocoa* dialog_;
+  MediaGalleryPrefId prefid_;
+  base::scoped_nsobject<MenuController> menu_controller_;
+}
+
+@property(nonatomic, assign) MediaGalleriesDialogCocoa* dialog;
+@property(nonatomic, assign) MediaGalleryPrefId prefid;

[Avi (use Gerrit), 2013/11/05 19:17:33]

prefid? I'd prefer prefID, or at least prefId.

And if these are never set except during construction, then just make your
intializer:

-initWithFrame:dialog:prefID:

and drop the properties.

[Greg Billock, 2013/11/06 18:28:25]

That sounds good. Will do.

+
+- (NSMenu*)menuForEvent:(NSEvent*)theEvent;
+
+@end
+
+@implementation MediaGalleriesCheckbox
+
+@synthesize dialog = dialog_;
+@synthesize prefid = prefid_;
+
+- (id)initWithFrame:(NSRect)frameRect {
+  if ((self = [super initWithFrame:frameRect])) {
+  }
+  return self;
+}
+
+- (NSMenu*)menuForEvent:(NSEvent*)theEvent {
+  menu_controller_.reset(
+    [[MenuController alloc] initWithModel:dialog_->GetContextMenuModel(prefid_)
+                   useWithPopUpButtonCell:NO]);
+  return [menu_controller_ menu];
+}
+
+@end
+
 namespace {
 
 const CGFloat kCheckboxMargin = 10;
@@ -288,8 +326,10 @@ void MediaGalleriesDialogCocoa::UpdateGalleryCheckbox(
     const MediaGalleryPrefInfo& gallery,
     bool permitted,
     CGFloat y_pos) {
-  base::scoped_nsobject<NSButton> checkbox(
-      [[NSButton alloc] initWithFrame:NSZeroRect]);
+  base::scoped_nsobject<MediaGalleriesCheckbox> checkbox(
+      [[MediaGalleriesCheckbox alloc] initWithFrame:NSZeroRect]);
+  [checkbox setDialog:this];
+  [checkbox setPrefid:gallery.pref_id];
   NSString* unique_id = GetUniqueIDForGallery(gallery);
   [[checkbox cell] setRepresentedObject:unique_id];
   [[checkbox cell] setLineBreakMode:NSLineBreakByTruncatingMiddle];
@@ -347,6 +387,11 @@ void MediaGalleriesDialogCocoa::OnConstrainedWindowClosed(
   controller_->DialogFinished(accepted_);
 }
 
+ui::MenuModel* MediaGalleriesDialogCocoa::GetContextMenuModel(
+    MediaGalleryPrefId prefid) {
+  return controller_->GetContextMenuModel(prefid);
+}
+
 // static
 MediaGalleriesDialog* MediaGalleriesDialog::Create(
     MediaGalleriesDialogController* controller) {