Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 465023002: Revert of ES6: Make Map/Set constructors support iterable values (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)
Modified:
6 years, 4 months ago
CC:
v8-dev, domenic
Project:
v8
Visibility:
Public.

Description

Revert of ES6: Make Map/Set constructors support iterable values (patchset #4 of https://codereview.chromium.org/466003002/) Reason for revert: TestSetConstructorIterableValue(WeakSet) fails on x64.debug Original issue's description: > ES6: Make Map/Set constructors support iterable values > > Same for WeakMap/WeakSet > > https://bugs.ecmascript.org/show_bug.cgi?id=3111 > > BUG=v8:3508 > LOG=Y > R=dslomov@chromium.org > > Committed: https://code.google.com/p/v8/source/detail?r=23091 TBR=adamk@chromium.org,dslomov@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -67 lines) Patch
M src/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/weak_collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/collections.js View 4 chunks +0 lines, -63 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
arv (Not doing code reviews)
Created Revert of ES6: Make Map/Set constructors support iterable values
6 years, 4 months ago (2014-08-12 21:28:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/arv@chromium.org/465023002/1
6 years, 4 months ago (2014-08-12 21:28:54 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 21:28:54 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-12 21:28:55 UTC) #4
arv (Not doing code reviews)
The CQ bit was checked by arv@chromium.org
6 years, 4 months ago (2014-08-12 21:31:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/arv@chromium.org/465023002/1
6 years, 4 months ago (2014-08-12 21:31:59 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 21:32:03 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 21:32:07 UTC) #8
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698