Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Unified Diff: Tools/GardeningServer/ui/ct-failure-card.html

Issue 464963003: Move commit list out its own model. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-failure-card.html
diff --git a/Tools/GardeningServer/ui/ct-failure-card.html b/Tools/GardeningServer/ui/ct-failure-card.html
index 32e63b5957b575f938526b39f8fc86ddf5654c18..054aa77bdd90a2956b1bec1609be33fc398fcbbf 100644
--- a/Tools/GardeningServer/ui/ct-failure-card.html
+++ b/Tools/GardeningServer/ui/ct-failure-card.html
@@ -65,9 +65,7 @@ found in the LICENSE file.
<ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid>
<div id="failure" class="{{ { snoozed: group.isSnoozed } | tokenList }}">
<ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list>
- <ct-commit-list first="{{ group.failures[0].lastPassingRevisions }}"
- last="{{ group.failures[0].firstFailingRevisions }}"
- commits="{{ commits }}"></ct-commit-list>
+ <ct-commit-list commitList="{{ _commits() }}"></ct-commit-list>
</div>
<div id="buttons">
<paper-button id="examine" on-tap="{{ examine }}" label="Examine"></paper-button>
@@ -82,7 +80,7 @@ found in the LICENSE file.
<script>
Polymer({
group: null,
- commits: {},
+ commits: null,
tree: '',
examine: function() {
@@ -96,6 +94,12 @@ found in the LICENSE file.
unsnooze: function() {
this.group.unsnooze();
},
+
+ _commits: function() {
+ if (!this.group)
+ return undefined;
+ return this.group.commitList(this.commits);
+ }
});
</script>
</polymer-element>

Powered by Google App Engine
This is Rietveld 408576698