sdk/lib/profiler/profiler.dart - Issue 464953002: Add VMMetric and some sample metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/profiler/profiler.dart

Issue 464953002: Add VMMetric and some sample metrics (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/profiler/profiler.dart

diff --git a/sdk/lib/profiler/profiler.dart b/sdk/lib/profiler/profiler.dart

index e30fd1dfb2e133ba65803d25df552f725bdce7ab..1834f37b8dbff1517b8617ef888e54518e61330c 100644

--- a/sdk/lib/profiler/profiler.dart

+++ b/sdk/lib/profiler/profiler.dart

@@ -77,9 +77,10 @@ abstract class Metric {

final String description;

Metric(this.name, this.description) {

- if (name.contains('/')) {

+ if ((name == 'vm') || name.contains('/')) {

throw new ArgumentError('Invalid Metric name.');

}

Map _toJSON();

« no previous file with comments | « runtime/vm/vm_sources.gypi ('k') | tests/lib/profiler/metrics_test.dart » ('j') | no next file with comments »