Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Issue 464923002: Correct browser side audio effect state for mediastream requests. (Closed)

Created:
6 years, 4 months ago by tommi (sloooow) - chröme
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org, ajm, vrk (LEFT CHROMIUM)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correct browser side audio effect state for mediastream requests. The problem was that MediaStreamDispatcher::IsAudioDuckingActive could return true incorrectly (i.e. when an input device was open but it was not actually opened with ducking enabled - as specified by the application). The reason for this is that the audio effect state as known by MediaStreamDispatcher reflects what the browser side delivers when an audio track has been opened but the browser side had not taken into account the stream options of the request. BUG=391414 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289286

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M content/browser/renderer_host/media/media_stream_manager.cc View 1 3 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tommi (sloooow) - chröme
Fix comment
6 years, 4 months ago (2014-08-12 14:24:09 UTC) #1
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-12 14:24:25 UTC) #2
tommi (sloooow) - chröme
Oops, this was supposed to be a proper review request... sorry about that. Victoria - ...
6 years, 4 months ago (2014-08-12 14:37:13 UTC) #3
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-13 08:12:22 UTC) #4
no longer working on chromium
lgtm
6 years, 4 months ago (2014-08-13 12:50:23 UTC) #5
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 4 months ago (2014-08-13 13:08:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/464923002/20001
6 years, 4 months ago (2014-08-13 13:09:15 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 14:16:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289286

Powered by Google App Engine
This is Rietveld 408576698