Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: Source/core/html/HTMLElement.cpp

Issue 464903002: Add contextmenu attribute for HTMLElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added more tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLElement.h ('k') | Source/core/html/HTMLElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLElement.cpp
diff --git a/Source/core/html/HTMLElement.cpp b/Source/core/html/HTMLElement.cpp
index 041571390d1c06175442ff1acafa8f5410bc8275..f9dff426403e18215fdd92b3f3597386140f0978 100644
--- a/Source/core/html/HTMLElement.cpp
+++ b/Source/core/html/HTMLElement.cpp
@@ -48,6 +48,7 @@
#include "core/html/HTMLBRElement.h"
#include "core/html/HTMLFormElement.h"
#include "core/html/HTMLInputElement.h"
+#include "core/html/HTMLMenuElement.h"
#include "core/html/HTMLTemplateElement.h"
#include "core/html/HTMLTextFormControlElement.h"
#include "core/html/parser/HTMLParserIdioms.h"
@@ -901,6 +902,40 @@ bool HTMLElement::isInteractiveContent() const
return false;
}
+
+HTMLMenuElement* HTMLElement::contextMenu() const
+{
+ const AtomicString& contextMenuId(fastGetAttribute(contextmenuAttr));
+ if (contextMenuId.isNull())
+ return nullptr;
+
+ Element* element = treeScope().getElementById(contextMenuId);
+ // Not checking if the menu element is of type "popup".
+ // Ignoring menu element type attribute is intentional according to the standard.
+ return isHTMLMenuElement(element) ? toHTMLMenuElement(element) : nullptr;
+}
+
+void HTMLElement::setContextMenu(HTMLMenuElement* contextMenu)
+{
+ if (!contextMenu) {
+ setAttribute(contextmenuAttr, "");
+ return;
+ }
+
+ // http://www.whatwg.org/specs/web-apps/current-work/multipage/infrastructure.html#reflecting-content-attributes-in-idl-attributes
+ // On setting, if the given element has an id attribute, and has the same home
+ // subtree as the element of the attribute being set, and the given element is the
+ // first element in that home subtree whose ID is the value of that id attribute,
+ // then the content attribute must be set to the value of that id attribute.
+ // Otherwise, the content attribute must be set to the empty string.
+ const AtomicString& contextMenuId(contextMenu->fastGetAttribute(idAttr));
+
+ if (!contextMenuId.isNull() && contextMenu == treeScope().getElementById(contextMenuId))
+ setAttribute(contextmenuAttr, contextMenuId);
+ else
+ setAttribute(contextmenuAttr, "");
+}
+
void HTMLElement::defaultEventHandler(Event* event)
{
if (event->type() == EventTypeNames::keypress && event->isKeyboardEvent()) {
« no previous file with comments | « Source/core/html/HTMLElement.h ('k') | Source/core/html/HTMLElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698