LayoutTests/fast/dom/HTMLElement/contextmenu.html - Issue 464903002: Add contextmenu attribute for HTMLElement.

Side by Side Diff: LayoutTests/fast/dom/HTMLElement/contextmenu.html

Issue 464903002: Add contextmenu attribute for HTMLElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <script>

	7

	8 description('Tests the contextmenu attribute.');
	tkent 2014/08/19 01:14:41 Inconsistent quote characters. You use single-quot Inconsistent quote characters. You use single-quotes in this line, and use double-quotes in many other lines. pals 2014/08/19 10:12:31 Done. Show quoted text On 2014/08/19 01:14:41, tkent wrote: > Inconsistent quote characters. > You use single-quotes in this line, and use double-quotes in many other lines. Done.
	9

	10 debug("Test with valid contextmenu attribute");

	11 document.write("<div id='container1' contextmenu='menu1'><menu id='menu1' type=' popup' label='menu 1'></menu></div>");

	12 shouldBeEqualToString("document.getElementById('container1').contextMenu.id", "m enu1");

	13 shouldBeEqualToString("document.getElementById('container1').contextMenu.type", "popup");

	14 shouldBeEqualToString("document.getElementById('container1').contextMenu.label", "menu 1");

	15

	16 debug("Test with invalid contextmenu attribute");

	17 document.write("<div id='container2' contextmenu='nonexistent_menu'><menu id='me nu2' type='popup' label='menu 2'></menu></div>");

	18 shouldBeNull("document.getElementById('container2').contextMenu");

	19
	tkent 2014/08/19 01:14:41 Need more getter test cases. - Pointing an ID of Need more getter test cases. - Pointing an ID of non-<menu> element - Pointing <menu> with non-popup type. - Pointing an ID which multiple elements have pals 2014/08/19 10:12:31 Done. Show quoted text On 2014/08/19 01:14:41, tkent wrote: > Need more getter test cases. > > - Pointing an ID of non-<menu> element > - Pointing <menu> with non-popup type. > - Pointing an ID which multiple elements have Done.
	20 debug("Test setting contextmenu attribute");

	21 document.write("<div id='container3'></div>");

	22 var menu = document.createElement('menu');

	23 menu.id = 'menu3';

	24 menu.type = 'popup';

	25 menu.label = 'menu 3';

	26 document.getElementById('container3').appendChild(menu);

	27 var container3 = document.getElementById('container3');

	28 container3.contextMenu = menu;

	29 shouldBeEqualToString("container3.contextMenu.id", "menu3");

	30 shouldBeEqualToString("container3.contextMenu.type", "popup");

	31 shouldBeEqualToString("container3.contextMenu.label", "menu 3");

	32

	33 debug("Test setting contextmenu attribute with menu element without id");

	34 document.write("<div id='container4'></div>");

	35 var menu1 = document.createElement('menu');

	36 menu1.type = 'popup';

	37 menu1.label = 'menu 4';

	38 document.getElementById('container4').appendChild(menu1);

	39 var container4 = document.getElementById('container4');

	40 container4.contextMenu = menu1;

	41 shouldBeNull("container4.contextMenu");
	tkent 2014/08/19 01:14:41 Also, check container4.hasAttribute('contextmenu') Also, check container4.hasAttribute('contextmenu') value and container4.getAttribute('contextmenu') value. pals 2014/08/19 10:12:31 Done. Show quoted text On 2014/08/19 01:14:41, tkent wrote: > Also, check container4.hasAttribute('contextmenu') value and > container4.getAttribute('contextmenu') value. Done.
	42

	43 debug("Test setting contextmenu attribute with multiple menu element with same i d");

	44 document.write("<div id='container5'></div>");

	45 var menu2 = document.createElement('menu');

	46 menu2.id = 'menu5';

	47 menu2.type = 'popup';

	48 menu2.label = 'menu 5';

	49 var menu3 = document.createElement('menu');

	50 menu3.id = 'menu5';

	51 menu3.type = 'popup';

	52 menu3.label = 'menu 6';

	53 document.getElementById('container5').appendChild(menu2);

	54 document.getElementById('container5').appendChild(menu3);

	55 var container5 = document.getElementById('container5');

	56 container5.contextMenu = menu3;

	57 shouldBeNull("container5.contextMenu");
	tkent 2014/08/19 01:14:41 Additionally, we should test: container5.context Additionally, we should test: container5.contextMenu = menu2; shouldBe("container5.contextMenu", "menu2"); pals 2014/08/19 10:12:32 Done. Show quoted text On 2014/08/19 01:14:41, tkent wrote: > Additionally, we should test: > container5.contextMenu = menu2; > shouldBe("container5.contextMenu", "menu2"); Done.
	58

	59 debug("Test setting contextmenu attribute to null");

	60 document.write("<div id='container6'></div>");
	tkent 2014/08/19 01:14:41 We should change the HTML to <div id='container We should change the HTML to <div id='container6' contextmenu='menu6'><menu id='menu6'></menu></div> pals 2014/08/19 10:12:31 Done. Show quoted text On 2014/08/19 01:14:41, tkent wrote: > We should change the HTML to > <div id='container6' contextmenu='menu6'><menu id='menu6'></menu></div> Done.
	61 var container6 = document.getElementById('container6');

	62 container6.contextMenu = null;

	63 shouldBeNull("container6.contextMenu");

	64

	65 debug("Test setting contextmenu attribute to some text");

	66 document.write("<div id='container7'></div>");

	67 var container7 = document.getElementById('container7');

	68 container7.contextMenu = "foobar";

	69 shouldBeNull("container7.contextMenu");

	70

	71 debug("Test setting contextmenu attribute to comment");

	72 document.write("<div id='container8'></div>");

	73 var container8 = document.getElementById('container8');

	74 container8.contextMenu = document.createComment('foo');

	75 shouldBeNull("container8.contextMenu");

	76

	77 debug("Test setting contextmenu attribute to menu without type");

	78 document.write("<div id='container9'></div>");

	79 var menu4 = document.createElement('menu');

	80 menu4.id = 'menu_without_type';

	81 menu4.label = 'menu without type';

	82 document.getElementById('container9').appendChild(menu4);

	83 var container9 = document.getElementById('container9');

	84 container9.contextMenu = menu4;

	85 shouldBeEqualToString("container9.contextMenu.id", "menu_without_type");

	86 shouldBeEqualToString("container9.contextMenu.type", "");

	87 shouldBeEqualToString("container9.contextMenu.label", "menu without type");

	88

	89 debug("Test setting contextmenu attribute to menu element which is in shadow dom ");

	90 document.write("<div id='container10'></div>");

	91 var menu5 = document.createElement('menu');

	92 menu5.id = 'menu_in_shadow_dom';

	93 menu5.label = 'menu in shadow dom';

	94 var container10 = document.getElementById('container10');

	95 container10.createShadowRoot().appendChild(menu5);

	96 container10.contextMenu = menu5;

	97 shouldBeNull("container10.contextMenu");

	98 </script>

	99 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLElement/contextmenu-expected.txt » ('j') | Source/core/html/HTMLElement.cpp » ('J')