Accept invalid Schemas for the managed storage API.

chrome/browser/extensions/api/storage/managed_value_store_cache.cc

Index: chrome/browser/extensions/api/storage/managed_value_store_cache.cc
diff --git a/chrome/browser/extensions/api/storage/managed_value_store_cache.cc b/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
index c9e9f4a4a4c08a0c8c6c464f0c30328cb8f01d94..012f5d664f1aa95ce458369f994f21e09ac2fa5e 100644
--- a/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
+++ b/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
@@ -206,7 +206,10 @@ void ManagedValueStoreCache::ExtensionTracker::LoadSchemasOnBlockingPool(
     std::string error;
     policy::Schema schema =
         StorageSchemaManifestHandler::GetSchema(it->get(), &error);
-    CHECK(schema.valid()) << error;
+    // If the schema is invalid then proceed with an empty schema. The extension
+    // will be listed in chrome://policy but won't be able to load any policies.

[not at google - send to devlin, 2014/08/13 17:27:31]

It'd be nice to try to recover the policy in this case, e.g. by re-installing
the extension. I've seen that requested before for enterprise extensions. I
can't find the bug but maybe asargent/erikkay can remember. Anyhow, not
something to try in this CL... but it'd be nice to have a bug to reference.

[Joao da Silva, 2014/08/14 11:56:57]

sgtm. Shouldn't we try to do the same recovery for non-enterprise extensions
too?

+    if (!schema.valid())
+      schema = policy::Schema();
     (*components)[(*it)->id()] = schema;
   }