Credential Manager: Renderer-side implementation.

components/password_manager/content/common/credential_manager_types.h

Index: components/password_manager/content/common/credential_manager_types.h
diff --git a/components/password_manager/content/common/credential_manager_types.h b/components/password_manager/content/common/credential_manager_types.h
new file mode 100644
index 0000000000000000000000000000000000000000..4c5738b7816c5577f60b58e549b7ba0b674e482c
--- /dev/null
+++ b/components/password_manager/content/common/credential_manager_types.h
@@ -0,0 +1,45 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_COMMON_CREDENTIAL_MANAGER_TYPES_H_
+#define COMPONENTS_PASSWORD_MANAGER_CONTENT_COMMON_CREDENTIAL_MANAGER_TYPES_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "base/strings/string16.h"
+#include "url/gurl.h"
+
+namespace password_manager {
+
+enum CredentialManagerCredentialType {
+  CREDENTIAL_MANAGER_CREDENTIAL_TYPE_UNKNOWN = 0,
+  CREDENTIAL_MANAGER_CREDENTIAL_TYPE_LOCAL,
+  CREDENTIAL_MANAGER_CREDENTIAL_TYPE_FEDERATED,
+  CREDENTIAL_MANAGER_CREDENTIAL_TYPE_LAST = CREDENTIAL_MANAGER_CREDENTIAL_TYPE_FEDERATED
+};
+
+struct CredentialManagerCredentialInfo {

[Ilya Sherman, 2014/08/15 20:42:37]

nit: This name is a bit repetitive -- perhaps just "CredentialInfo" would
suffice?

+  CredentialManagerCredentialInfo();
+  CredentialManagerCredentialInfo(base::string16 id, base::string16 name, GURL avatarURL);

[Ilya Sherman, 2014/08/15 20:42:37]

nit: Pass by const-ref.

+  ~CredentialManagerCredentialInfo();
+
+  CredentialManagerCredentialType type;
+
+  base::string16 id;
+  base::string16 name;
+  GURL avatarURL;
+
+  // TODO(mkwst): The meaning of this field varies with the |type|. This will
+  // almost certainly have to evolve into something more complex as the API
+  // changes, but for the moment it's the simplest thing that works.
+  base::string16 data;

[Ilya Sherman, 2014/08/15 20:42:38]

Hmm, I think I'd prefer to have more fields, where some can be unset, rather
than a single field that's super generic.

+};
+
+}  // namespace password_manager
+
+#endif  // COMPONENTS_PASSWORD_MANAGER_CONTENT_COMMON_CREDENTIAL_MANAGER_TYPES_H_
+
+