Credential Manager: Renderer-side implementation.

content/renderer/renderer_webkitplatformsupport_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
@@ skipping 854 matching lines @@
 
 //------------------------------------------------------------------------------
 
 WebBlobRegistry* RendererWebKitPlatformSupportImpl::blobRegistry() {
   // blob_registry_ can be NULL when running some tests.
   return blob_registry_.get();
 }
 
 //------------------------------------------------------------------------------
 
+blink::WebCredentialManager*
+RendererWebKitPlatformSupportImpl::credentialManager() {
+  return GetContentClient()->renderer()->GetCredentialManager();

[jam, 2014/08/19 19:55:31]

the pattern we had used for the content refactoring is that interfaces which
blink needs and that are implemented by chrome are set directly by chrome. that
way we dont have to go through content just to ask chrome. as an example, see
ChromeContentRendererClient::RenderViewCreated which creates a bunch of classes.
in their constructors, tehy do something like
render_view->GetWebView()->setFooClient

[Mike West, 2014/08/20 13:17:20]

That keeps //content clean at the expense of making Blink a bit more complex,
which is a shame. :( *shrug* Regardless, I've uploaded
https://codereview.chromium.org/488993003/ to prepare for moving things around
in this patch.

+}
+
+//------------------------------------------------------------------------------
+
 void RendererWebKitPlatformSupportImpl::sampleGamepads(WebGamepads& gamepads) {
   DCHECK(gamepad_provider_);
   gamepad_provider_->SampleGamepads(gamepads);
 }
 
 //------------------------------------------------------------------------------
 
 WebRTCPeerConnectionHandler*
 RendererWebKitPlatformSupportImpl::createRTCPeerConnectionHandler(
     WebRTCPeerConnectionHandlerClient* client) {
@@ skipping 315 matching lines @@
 
 //------------------------------------------------------------------------------
 
 // static
 void RendererWebKitPlatformSupportImpl::MockBatteryStatusChangedForTesting(
     const blink::WebBatteryStatus& status) {
   g_test_battery_status_dispatcher.Get().PostBatteryStatusChange(status);
 }
 
 }  // namespace content