Credential Manager: Renderer-side implementation.

chrome/chrome_common.gypi

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # File lists shared with GN build.
     'chrome_common_sources': [
       '../apps/app_shim/app_shim_launch.h',
       '../apps/app_shim/app_shim_messages.h',
@@ skipping 350 matching lines @@
           ],
         }],
         ['OS=="mac"', {
           'sources': [ '<@(chrome_common_mac_sources)' ],
         }],
         ['OS != "ios"', {
           'dependencies': [
             '<(DEPTH)/chrome/common/extensions/api/api.gyp:chrome_api',
             '<(DEPTH)/components/components.gyp:autofill_core_common',
             '<(DEPTH)/components/components.gyp:autofill_content_common',
             '<(DEPTH)/components/components.gyp:password_manager_core_common',

[Ilya Sherman, 2014/08/19 23:55:51]

Hmm, if iOS already doesn't use the password manager, is there any reason to
distinguish between "core" and "content"?

Or, perhaps this line doesn't need to be in the 'OS != "ios"' section?

[vabr (Chromium), 2014/08/20 10:57:47]

Yeah, I actually don't know why all the *_core_common targets are excluded from
iOS (saying that while being responsible for this particular one). Looks like a
good idea to move the *_core_common deps up to the all-including section.

[Mike West, 2014/08/20 13:17:18]

Let's do that in a separate CL? :)

[Mike West, 2014/08/20 13:17:18]

1. Honestly, it's a little bit unclear how we'd go about implementing the API
I'm prototyping in iOS.

2. The message definitions can't be in 'core/common' because they rely on
'content/public/common/common_param_traits.h' for the 'IPC::ParamTraits<GURL>'
definition, and core can't depend on content. :/

[vabr (Chromium), 2014/08/20 14:40:34]

SGTM.

+            '<(DEPTH)/components/components.gyp:password_manager_content_common',
             '<(DEPTH)/components/components.gyp:signin_core_common',
             '<(DEPTH)/components/components.gyp:translate_content_common',
             '<(DEPTH)/components/components.gyp:visitedlink_common',
             '<(DEPTH)/extensions/common/api/api.gyp:extensions_api',
             '<(DEPTH)/extensions/extensions.gyp:extensions_common',
             '<(DEPTH)/ipc/ipc.gyp:ipc',
             '<(DEPTH)/third_party/adobe/flash/flash_player.gyp:flapper_version_h',
             '<(DEPTH)/third_party/re2/re2.gyp:re2',
             '<(DEPTH)/third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h',
           ],
@@ skipping 312 matching lines @@
         'common/safe_browsing/csd.proto'
       ],
       'variables': {
         'proto_in_dir': 'common/safe_browsing',
         'proto_out_dir': 'chrome/common/safe_browsing',
       },
       'includes': [ '../build/protoc.gypi' ],
     },
   ],
 }