Issue 464853002: Mac Video Capture: correct to float the erroneous handling of frame rate as int.

Issue 464853002: Mac Video Capture: correct to float the erroneous handling of frame rate as int. (Closed)

Created:
6 years, 4 months ago by mcasas

Modified:
6 years, 4 months ago

Reviewers:
tommi (sloooow) - chröme, andresp-chromium

CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Mac Video Capture: correct to float the erroneous handling of frame rate as int. This is a fix for a latent bug. Tentatively, this is also causing http://crbug.com/394315. BUG=380463, 394315 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289008

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -11 lines)			Patch
M	media/video/capture/mac/platform_video_capturing_mac.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	media/video/capture/mac/video_capture_device_avfoundation_mac.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	media/video/capture/mac/video_capture_device_avfoundation_mac.mm	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	media/video/capture/mac/video_capture_device_qtkit_mac.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	media/video/capture/mac/video_capture_device_qtkit_mac.mm	View	3 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

andresp-chromium

On 2014/08/12 10:47:58, mcasas wrote: > andresp@ PTAL. > tommi@ Owners RS/ PTAL. LGTM. Since ...

6 years, 4 months ago (2014-08-12 12:56:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/464853002/20001

6 years, 4 months ago (2014-08-12 13:57:35 UTC) #5

Message was sent while issue was closed.

Change committed as 289008