Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 464823003: [svg] getScreenCTM reporting incorrect transformation matrix. (Closed)

Created:
6 years, 4 months ago by Erik Dahlström (inactive)
Modified:
6 years, 3 months ago
Reviewers:
davve, pdr., fs
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[svg] getScreenCTM reporting incorrect transformation matrix. BUG=402790 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181197

Patch Set 1 #

Patch Set 2 : fix typo #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -6 lines) Patch
A LayoutTests/fast/svg/getScreenCTM.html View 1 1 chunk +61 lines, -0 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Erik Dahlström (inactive)
6 years, 4 months ago (2014-08-12 11:06:39 UTC) #1
fs
LGTM, but I'd suggest also checking that other callsites (of currentViewportSize - like SVGImage::containerSize) have ...
6 years, 4 months ago (2014-08-20 17:23:47 UTC) #2
Erik Dahlström (inactive)
On 2014/08/20 17:23:47, fs wrote: > LGTM, but I'd suggest also checking that other callsites ...
6 years, 3 months ago (2014-09-01 15:31:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/464823003/60001
6 years, 3 months ago (2014-09-01 15:31:59 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 16:31:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 181197

Powered by Google App Engine
This is Rietveld 408576698