DevTools: Simplify isArrayLike() in injected script and extend InjectedScriptHost.type()

DevTools: Simplify isArrayLike() in injected script and extend InjectedScriptHost.type()

R=yurys@chromium.org, yurys

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180168

[yurys, 2014-08-12 08:52:48]

https://codereview.chromium.org/464793002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp (right):

https://codereview.chromium.org/464793002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp:207: ||
V8Uint8ClampedArray::hasInstance(value, isolate)
Why value->IsTypedArray check above is not enough?

[aandrey, 2014-08-12 09:49:48]

https://codereview.chromium.org/464793002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp (right):

https://codereview.chromium.org/464793002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp:207: ||
V8Uint8ClampedArray::hasInstance(value, isolate)
On 2014/08/12 08:52:48, yurys wrote:
> Why value->IsTypedArray check above is not enough?

You're right. Removed.

[yurys, 2014-08-12 12:51:05]

lgtm

[commit-bot: I haz the power, 2014-08-12 12:52:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/464793002/40001

[commit-bot: I haz the power, 2014-08-12 13:55:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)

[commit-bot: I haz the power, 2014-08-12 14:58:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 14:58:49]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)

[aandrey, 2014-08-12 20:10:37]

The CQ bit was checked by aandrey@chromium.org

[aandrey, 2014-08-12 20:11:38]

The CQ bit was unchecked by aandrey@chromium.org

[aandrey, 2014-08-13 09:59:59]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-08-13 10:01:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/464793002/60001

[commit-bot: I haz the power, 2014-08-13 11:04:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22504)

[commit-bot: I haz the power, 2014-08-13 12:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 12:07:10]

Failed to apply patch for
LayoutTests/inspector/console/console-eval-syntax-error-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
  Hunk #1 FAILED at 1.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/inspector/console/console-eval-syntax-error-expected.txt.rej

Patch:      
LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
Index: LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
diff --git
a/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
b/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
index
a83fd442e5400a9c86a865fea3bccf29551efb1f..3b250890da7211044c39896a686c231b69c7b5af
100644
--- a/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
+++ b/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
@@ -1,5 +1,5 @@
 Tests that evaluating an expression with a syntax error in the console won't
crash the browser. Bug 61194.
 
 foo().
-Uncaught SyntaxError: Unexpected token } VM:736
+Uncaught SyntaxError: Unexpected token } VM:732

[aandrey, 2014-08-13 12:18:17]

Committed patchset #5 manually as 180168 (presubmit successful).