Source/platform/exported/WebCredential.cpp - Issue 464783003: Credential manager: Convert strings to URLs early.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/exported/WebCredential.cpp

Issue 464783003: Credential manager: Convert strings to URLs early. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Feedback. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/exported/WebCredential.cpp

diff --git a/Source/platform/exported/WebCredential.cpp b/Source/platform/exported/WebCredential.cpp

index cc3463450290a95bd0235c7b556e5f3e2c79c5fb..db6097c1d75ffb0324ce9f746d39dd0a15dce89d 100644

--- a/Source/platform/exported/WebCredential.cpp

+++ b/Source/platform/exported/WebCredential.cpp

@@ -9,7 +9,7 @@

namespace blink {

-WebCredential::WebCredential(const WebString& id, const WebString& name, const WebString& avatarURL)

+WebCredential::WebCredential(const WebString& id, const WebString& name, const WebURL& avatarURL)

: m_platformCredential(PlatformCredential::create(id, name, avatarURL))

{

}

@@ -39,7 +39,7 @@ WebString WebCredential::name() const

return m_platformCredential->name();

}

-WebString WebCredential::avatarURL() const

+WebURL WebCredential::avatarURL() const

{

return m_platformCredential->avatarURL();

}