Source/platform/credentialmanager/PlatformCredential.cpp - Issue 464783003: Credential manager: Convert strings to URLs early.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/credentialmanager/PlatformCredential.cpp

Issue 464783003: Credential manager: Convert strings to URLs early. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Feedback. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/credentialmanager/PlatformCredential.cpp

diff --git a/Source/platform/credentialmanager/PlatformCredential.cpp b/Source/platform/credentialmanager/PlatformCredential.cpp

index 225171d927d56166f861a8115e85914811c4b63b..1b8a359534c109e82939b4ec4f5ec12d99e263de 100644

--- a/Source/platform/credentialmanager/PlatformCredential.cpp

+++ b/Source/platform/credentialmanager/PlatformCredential.cpp

@@ -7,12 +7,12 @@

namespace blink {

-PlatformCredential* PlatformCredential::create(const String& id, const String& name, const String& avatarURL)

+PlatformCredential* PlatformCredential::create(const String& id, const String& name, const KURL& avatarURL)

{

return new PlatformCredential(id, name, avatarURL);

}

-PlatformCredential::PlatformCredential(const String& id, const String& name, const String& avatarURL)

+PlatformCredential::PlatformCredential(const String& id, const String& name, const KURL& avatarURL)

: m_id(id)

, m_name(name)

, m_avatarURL(avatarURL)