Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: Source/modules/credentialmanager/FederatedCredential.cpp

Issue 464783003: Credential manager: Convert strings to URLs early. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Feedback. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/FederatedCredential.cpp
diff --git a/Source/modules/credentialmanager/FederatedCredential.cpp b/Source/modules/credentialmanager/FederatedCredential.cpp
index ec123c6b36186770b7c2566201a74ee81975c3bc..fe110cd5b7de67be058c0171606747eeb0aaabad 100644
--- a/Source/modules/credentialmanager/FederatedCredential.cpp
+++ b/Source/modules/credentialmanager/FederatedCredential.cpp
@@ -4,21 +4,27 @@
#include "config.h"
#include "modules/credentialmanager/FederatedCredential.h"
+
+#include "bindings/core/v8/ExceptionState.h"
#include "platform/credentialmanager/PlatformFederatedCredential.h"
namespace blink {
-FederatedCredential* FederatedCredential::create(const String& id, const String& name, const String& avatarURL, const String& federation)
+FederatedCredential* FederatedCredential::create(const String& id, const String& name, const String& avatar, const String& federation, ExceptionState& exceptionState)
{
- return new FederatedCredential(id, name, avatarURL, federation);
+ KURL avatarURL = parseStringAsURL(avatar, exceptionState);
+ KURL federationURL = parseStringAsURL(federation, exceptionState);
+ if (exceptionState.hadException())
+ return nullptr;
+ return new FederatedCredential(id, name, avatarURL, federationURL);
}
-FederatedCredential::FederatedCredential(const String& id, const String& name, const String& avatarURL, const String& federation)
- : Credential(PlatformFederatedCredential::create(id, name, avatarURL, federation))
+FederatedCredential::FederatedCredential(const String& id, const String& name, const KURL& avatar, const KURL& federation)
+ : Credential(PlatformFederatedCredential::create(id, name, avatar, federation))
{
}
-const String& FederatedCredential::federation() const
+const KURL& FederatedCredential::federation() const
{
return static_cast<PlatformFederatedCredential*>(m_platformCredential.get())->federation();
}
« no previous file with comments | « Source/modules/credentialmanager/FederatedCredential.h ('k') | Source/modules/credentialmanager/FederatedCredential.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698