Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1580)

Unified Diff: Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 464783003: Credential manager: Convert strings to URLs early. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Feedback. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/CredentialsContainer.cpp
diff --git a/Source/modules/credentialmanager/CredentialsContainer.cpp b/Source/modules/credentialmanager/CredentialsContainer.cpp
index f4d92beba2ed31474c2b555cf4b4bcb3281a8ffd..34e5d6baa88e3ee0998b6989685781f9dc430e68 100644
--- a/Source/modules/credentialmanager/CredentialsContainer.cpp
+++ b/Source/modules/credentialmanager/CredentialsContainer.cpp
@@ -62,6 +62,7 @@ public:
virtual void onSuccess(WebCredential* credential) OVERRIDE
{
+ // FIXME: Split this into Local/Federated types.
m_resolver->resolve(Credential::create(credential->id(), credential->name(), credential->avatarURL()));
}
« no previous file with comments | « Source/modules/credentialmanager/Credential.cpp ('k') | Source/modules/credentialmanager/FederatedCredential.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698