Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: Source/modules/credentialmanager/Credential.h

Issue 464783003: Credential manager: Convert strings to URLs early. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Feedback. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/Credential.h
diff --git a/Source/modules/credentialmanager/Credential.h b/Source/modules/credentialmanager/Credential.h
index c590cb84be9ab68814b8ec335bb5c43fbc8a1f24..3b026b2fa8237463cb49703f1a92956b56589214 100644
--- a/Source/modules/credentialmanager/Credential.h
+++ b/Source/modules/credentialmanager/Credential.h
@@ -9,25 +9,31 @@
#include "bindings/core/v8/SerializedScriptValue.h"
#include "platform/credentialmanager/PlatformCredential.h"
#include "platform/heap/Handle.h"
+#include "platform/weborigin/KURL.h"
namespace blink {
class WebCredential;
+class ExceptionState;
class Credential : public GarbageCollected<Credential>, public ScriptWrappable {
public:
- static Credential* create(const String& id, const String& name, const String& avatarURL);
+ static Credential* create(const String& id, const String& name, const KURL& avatar);
+ static Credential* create(const String& id, const String& name, const String& avatar, ExceptionState&);
// Credential.idl
const String& id() const { return m_platformCredential->id(); }
const String& name() const { return m_platformCredential->name(); }
- const String& avatarURL() const { return m_platformCredential->avatarURL(); }
+ const KURL& avatarURL() const { return m_platformCredential->avatarURL(); }
virtual void trace(Visitor*);
protected:
explicit Credential(PlatformCredential*);
- Credential(const String& id, const String& name, const String& avatarURL);
+ Credential(const String& id, const String& name, const KURL& avatar);
+
+ // Parses a string as a KURL. Throws an exception via |exceptionState| if an invalid URL is produced.
+ static KURL parseStringAsURL(const String&, ExceptionState&);
Member<PlatformCredential> m_platformCredential;
};
« no previous file with comments | « LayoutTests/http/tests/credentialmanager/localcredential-basics.html ('k') | Source/modules/credentialmanager/Credential.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698