Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: Source/modules/credentialmanager/LocalCredential.cpp

Issue 464783003: Credential manager: Convert strings to URLs early. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/LocalCredential.cpp
diff --git a/Source/modules/credentialmanager/LocalCredential.cpp b/Source/modules/credentialmanager/LocalCredential.cpp
index 03dbcea512b928532979d642d42ed6d96964c887..e5684f27a23189619b0681f3bf3f81698c72ab3f 100644
--- a/Source/modules/credentialmanager/LocalCredential.cpp
+++ b/Source/modules/credentialmanager/LocalCredential.cpp
@@ -4,16 +4,21 @@
#include "config.h"
#include "modules/credentialmanager/LocalCredential.h"
+
+#include "bindings/core/v8/ExceptionState.h"
#include "platform/credentialmanager/PlatformLocalCredential.h"
namespace blink {
-LocalCredential* LocalCredential::create(const String& id, const String& name, const String& avatarURL, const String& password)
+LocalCredential* LocalCredential::create(const String& id, const String& name, const String& avatar, const String& password, ExceptionState& exceptionState)
{
+ KURL avatarURL = parseStringAsURL(avatar, exceptionState);
+ if (exceptionState.hadException())
+ return nullptr;
return new LocalCredential(id, name, avatarURL, password);
}
-LocalCredential::LocalCredential(const String& id, const String& name, const String& avatarURL, const String& password)
+LocalCredential::LocalCredential(const String& id, const String& name, const KURL& avatarURL, const String& password)
: Credential(PlatformLocalCredential::create(id, name, avatarURL, password))
{
}

Powered by Google App Engine
This is Rietveld 408576698