Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: Source/modules/credentialmanager/LocalCredential.cpp

Issue 464783003: Credential manager: Convert strings to URLs early. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Feedback. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/credentialmanager/LocalCredential.h" 6 #include "modules/credentialmanager/LocalCredential.h"
7
8 #include "bindings/core/v8/ExceptionState.h"
7 #include "platform/credentialmanager/PlatformLocalCredential.h" 9 #include "platform/credentialmanager/PlatformLocalCredential.h"
8 10
9 namespace blink { 11 namespace blink {
10 12
11 LocalCredential* LocalCredential::create(const String& id, const String& name, c onst String& avatarURL, const String& password) 13 LocalCredential* LocalCredential::create(const String& id, const String& name, c onst String& avatar, const String& password, ExceptionState& exceptionState)
12 { 14 {
15 KURL avatarURL = parseStringAsURL(avatar, exceptionState);
16 if (exceptionState.hadException())
17 return nullptr;
13 return new LocalCredential(id, name, avatarURL, password); 18 return new LocalCredential(id, name, avatarURL, password);
14 } 19 }
15 20
16 LocalCredential::LocalCredential(const String& id, const String& name, const Str ing& avatarURL, const String& password) 21 LocalCredential::LocalCredential(const String& id, const String& name, const KUR L& avatar, const String& password)
17 : Credential(PlatformLocalCredential::create(id, name, avatarURL, password)) 22 : Credential(PlatformLocalCredential::create(id, name, avatar, password))
18 { 23 {
19 } 24 }
20 25
21 const String& LocalCredential::password() const 26 const String& LocalCredential::password() const
22 { 27 {
23 return static_cast<PlatformLocalCredential*>(m_platformCredential.get())->pa ssword(); 28 return static_cast<PlatformLocalCredential*>(m_platformCredential.get())->pa ssword();
24 } 29 }
25 30
26 } // namespace blink 31 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/credentialmanager/LocalCredential.h ('k') | Source/modules/credentialmanager/LocalCredential.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698