Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: Source/modules/credentialmanager/FederatedCredential.cpp

Issue 464783003: Credential manager: Convert strings to URLs early. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Feedback. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/credentialmanager/FederatedCredential.h" 6 #include "modules/credentialmanager/FederatedCredential.h"
7
8 #include "bindings/core/v8/ExceptionState.h"
7 #include "platform/credentialmanager/PlatformFederatedCredential.h" 9 #include "platform/credentialmanager/PlatformFederatedCredential.h"
8 10
9 namespace blink { 11 namespace blink {
10 12
11 FederatedCredential* FederatedCredential::create(const String& id, const String& name, const String& avatarURL, const String& federation) 13 FederatedCredential* FederatedCredential::create(const String& id, const String& name, const String& avatar, const String& federation, ExceptionState& exception State)
12 { 14 {
13 return new FederatedCredential(id, name, avatarURL, federation); 15 KURL avatarURL = parseStringAsURL(avatar, exceptionState);
16 KURL federationURL = parseStringAsURL(federation, exceptionState);
17 if (exceptionState.hadException())
18 return nullptr;
19 return new FederatedCredential(id, name, avatarURL, federationURL);
14 } 20 }
15 21
16 FederatedCredential::FederatedCredential(const String& id, const String& name, c onst String& avatarURL, const String& federation) 22 FederatedCredential::FederatedCredential(const String& id, const String& name, c onst KURL& avatar, const KURL& federation)
17 : Credential(PlatformFederatedCredential::create(id, name, avatarURL, federa tion)) 23 : Credential(PlatformFederatedCredential::create(id, name, avatar, federatio n))
18 { 24 {
19 } 25 }
20 26
21 const String& FederatedCredential::federation() const 27 const KURL& FederatedCredential::federation() const
22 { 28 {
23 return static_cast<PlatformFederatedCredential*>(m_platformCredential.get()) ->federation(); 29 return static_cast<PlatformFederatedCredential*>(m_platformCredential.get()) ->federation();
24 } 30 }
25 31
26 } // namespace blink 32 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/credentialmanager/FederatedCredential.h ('k') | Source/modules/credentialmanager/FederatedCredential.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698