LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html - Issue 464783003: Credential manager: Convert strings to URLs early.

Side by Side Diff: LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html

Issue 464783003: Credential manager: Convert strings to URLs early. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Credential Manager: FederatedCredential basics.</title>	2 <title>Credential Manager: FederatedCredential basics.</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="/serviceworker/resources/interfaces.js"></script>	5 <script src="/serviceworker/resources/interfaces.js"></script>

6 <script>	6 <script>

7 test(function() {	7 test(function() {

8 var credential = new FederatedCredential('id', 'name', 'https://example.com/ avatar.png', 'https://federation.net/');	8 var credential = new FederatedCredential('id', 'name', 'https://example.com/ avatar.png', 'https://federation.net/');

9	9

10 assert_true(credential instanceof Credential);	10 assert_true(credential instanceof Credential);

11 assert_true(credential instanceof FederatedCredential);	11 assert_true(credential instanceof FederatedCredential);

12	12

13 verifyInterface('FederatedCredential', credential, {	13 verifyInterface('FederatedCredential', credential, {

14 id: 'string',	14 id: 'string',

15 name: 'string',	15 name: 'string',

16 avatarURL: 'string',	16 avatarURL: 'string',

17 federation: 'string'	17 federation: 'string'

18 });	18 });

19	19

20 assert_equals(credential.id, 'id');	20 assert_equals(credential.id, 'id');

21 assert_equals(credential.name, 'name');	21 assert_equals(credential.name, 'name');

22 assert_equals(credential.avatarURL, 'https://example.com/avatar.png');	22 assert_equals(credential.avatarURL, 'https://example.com/avatar.png');

23 assert_equals(credential.federation, 'https://federation.net/');	23 assert_equals(credential.federation, 'https://federation.net/');

24 }, 'Interfaces and attributes of FederatedCredential');	24 }, 'Interfaces and attributes of FederatedCredential');

	25

	26 test(function() {

	27 try {

	28 var credential = new FederatedCredential('id', 'name', '-', 'https://fed eration.net/');
	philipj_slow 2014/08/12 09:42:40 It looks like assert_throws would simplify this to It looks like assert_throws would simplify this to assert_throws(new SyntaxError(), function() { new FederatedCredential('id', 'name', '-', 'https://federation.net/'); });
	29 assert_unreached("Creating a credential with an invalid URL should throw a SyntaxError.");

	30 } catch (e) {

	31 assert_equals(e.name, "SyntaxError");

	32 }

	33 }, 'Invalid avatar URL throws.');
	philipj_slow 2014/08/12 09:42:40 In web-platform-tests I've been advised to not put In web-platform-tests I've been advised to not put the pass condition in the test name, but rather just say what the test does. I think it's good advice, but it's a matter of style so take your pick :)
	34

	35 test(function() {

	36 try {

	37 var credential = new FederatedCredential('id', 'name', 'https://example. com/avatar.png', '-');

	38 assert_unreached("Creating a credential with an invalid URL should throw a SyntaxError.");

	39 } catch (e) {

	40 assert_equals(e.name, "SyntaxError");

	41 }

	42 }, 'Invalid federation URL throws.');

25 </script>	43 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/credentialmanager/localcredential-basics.html » ('j') | Source/modules/credentialmanager/LocalCredential.h » ('J')