Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: extensions/browser/api/extensions_api_client.h

Issue 464753002: Fix HidService lifetime issues. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « device/hid/hid_service_unittest.cc ('k') | extensions/browser/api/extensions_api_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_ 5 #ifndef EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_
6 #define EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_ 6 #define EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "extensions/browser/api/storage/settings_namespace.h" 11 #include "extensions/browser/api/storage/settings_namespace.h"
12 12
13 class GURL; 13 class GURL;
14 14
15 template <class T> 15 template <class T>
16 class ObserverListThreadSafe; 16 class ObserverListThreadSafe;
17 17
18 namespace content { 18 namespace content {
19 class BrowserContext; 19 class BrowserContext;
20 } 20 }
21 21
22 namespace device {
23 class HidService;
24 }
25
26 namespace extensions { 22 namespace extensions {
27 23
28 class AppViewGuestDelegate; 24 class AppViewGuestDelegate;
29 class WebViewGuest; 25 class WebViewGuest;
30 class WebViewGuestDelegate; 26 class WebViewGuestDelegate;
31 class WebViewPermissionHelper; 27 class WebViewPermissionHelper;
32 class WebViewPermissionHelperDelegate; 28 class WebViewPermissionHelperDelegate;
33 class SettingsObserver; 29 class SettingsObserver;
34 class SettingsStorageFactory; 30 class SettingsStorageFactory;
35 class ValueStoreCache; 31 class ValueStoreCache;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 // Denies the embedding requested by the <appview> specified by 65 // Denies the embedding requested by the <appview> specified by
70 // |guest_instance_id|. Returns true if the operation completes successfully. 66 // |guest_instance_id|. Returns true if the operation completes successfully.
71 virtual bool AppViewInternalDenyRequest( 67 virtual bool AppViewInternalDenyRequest(
72 content::BrowserContext* browser_context, 68 content::BrowserContext* browser_context,
73 int guest_instance_id, 69 int guest_instance_id,
74 const std::string& guest_extension_id); 70 const std::string& guest_extension_id);
75 71
76 // Creates the AppViewGuestDelegate. 72 // Creates the AppViewGuestDelegate.
77 virtual AppViewGuestDelegate* CreateAppViewGuestDelegate() const; 73 virtual AppViewGuestDelegate* CreateAppViewGuestDelegate() const;
78 74
79 // Returns the HidService instance for this embedder.
80 virtual device::HidService* GetHidService();
81
82 // Returns a delegate for some of WebViewGuest's behavior. The caller owns the 75 // Returns a delegate for some of WebViewGuest's behavior. The caller owns the
83 // returned WebViewGuestDelegate. 76 // returned WebViewGuestDelegate.
84 virtual WebViewGuestDelegate* CreateWebViewGuestDelegate ( 77 virtual WebViewGuestDelegate* CreateWebViewGuestDelegate (
85 WebViewGuest* web_view_guest) const; 78 WebViewGuest* web_view_guest) const;
86 79
87 // Returns a delegate for some of WebViewPermissionHelper's behavior. The 80 // Returns a delegate for some of WebViewPermissionHelper's behavior. The
88 // caller owns the returned WebViewPermissionHelperDelegate. 81 // caller owns the returned WebViewPermissionHelperDelegate.
89 virtual WebViewPermissionHelperDelegate* 82 virtual WebViewPermissionHelperDelegate*
90 CreateWebViewPermissionHelperDelegate ( 83 CreateWebViewPermissionHelperDelegate (
91 WebViewPermissionHelper* web_view_permission_helper) const; 84 WebViewPermissionHelper* web_view_permission_helper) const;
92 85
93 virtual void RegisterGuestViewTypes() {} 86 virtual void RegisterGuestViewTypes() {}
94 87
95 // NOTE: If this interface gains too many methods (perhaps more than 20) it 88 // NOTE: If this interface gains too many methods (perhaps more than 20) it
96 // should be split into one interface per API. 89 // should be split into one interface per API.
97 }; 90 };
98 91
99 } // namespace extensions 92 } // namespace extensions
100 93
101 #endif // EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_ 94 #endif // EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_
OLDNEW
« no previous file with comments | « device/hid/hid_service_unittest.cc ('k') | extensions/browser/api/extensions_api_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698