Fix HidService lifetime issues.

device/hid/hid_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/hid/hid_service.h"
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/memory/scoped_vector.h"
+#include "base/message_loop/message_loop.h"
 #include "base/stl_util.h"
 #include "base/threading/thread_restrictions.h"
 
 #if defined(OS_LINUX) && defined(USE_UDEV)
 #include "device/hid/hid_service_linux.h"
 #elif defined(OS_MACOSX)
 #include "device/hid/hid_service_mac.h"
 #else
 #include "device/hid/hid_service_win.h"
 #endif
 
 namespace device {
 
-HidService* HidService::Create(
+namespace {
+
+// TODO(rockot/reillyg): This is pretty awful all around. There is a combination
+// of constraints here: HidService doesn't know about //content, it must be able
+// to talk to the PermissionBrokerClient on ChromeOS (UI thread), and it's
+// expected to live and die on the FILE thread (for now). Solution? Make it a
+// singleton whose instance getter takes a UI message loop proxy, and let the
+// lifetime of the HidService be managed by a MessageLoop::DestructionObserver.
+//
+// The right long-term solution is probably a mojo service.  A tolerable
+// medium-term solution is up for debate.
+class HidServiceDestroyer : public base::MessageLoop::DestructionObserver {
+ public:
+  explicit HidServiceDestroyer(HidService* hid_service)
+      : hid_service_(hid_service) {}
+  virtual ~HidServiceDestroyer() {}
+
+ private:
+  // base::MessageLoop::DestructionObserver implementation.
+  virtual void WillDestroyCurrentMessageLoop() OVERRIDE {
+    base::MessageLoop::current()->RemoveDestructionObserver(this);
+    delete hid_service_;
+    delete this;

[rpaquay, 2014/08/26 17:35:12]

Are you sure "delete this" is ok here? I am not too familiar with
DestructionObserver behavior, but I don't see any other implementation having a
"delete this" inside.

+  }
+
+  HidService* hid_service_;
+};
+
+HidService* g_service = NULL;
+
+}  // namespace
+
+HidService* HidService::GetInstance(
     scoped_refptr<base::MessageLoopProxy> ui_message_loop) {
+  if (g_service == NULL) {

[rpaquay, 2014/08/26 17:35:12]

Maybe it would it be desirable to add a "dcheck" somehow that "GetInstance" is
not called after "WillDestroyCurrentMessageLoop()" is called? (to avoid
accidentally re-creating after shutting down).

 #if defined(OS_LINUX) && defined(USE_UDEV)
-  return new HidServiceLinux(ui_message_loop);
+    g_service = new HidServiceLinux(ui_message_loop);
 #elif defined(OS_MACOSX)
-  return new HidServiceMac();
+    g_service = new HidServiceMac();
 #elif defined(OS_WIN)
-  return new HidServiceWin();
-#else
-  return NULL;
+    g_service = new HidServiceWin();
 #endif
+    if (g_service != NULL) {
+      HidServiceDestroyer* destroyer = new HidServiceDestroyer(g_service);
+      base::MessageLoop::current()->AddDestructionObserver(destroyer);
+    }
+  }
+  return g_service;
 }
 
 HidService::~HidService() {
   DCHECK(thread_checker_.CalledOnValidThread());
 }
 
 void HidService::GetDevices(std::vector<HidDeviceInfo>* devices) {
   DCHECK(thread_checker_.CalledOnValidThread());
   STLClearObject(devices);
   for (DeviceMap::iterator it = devices_.begin();
@@ skipping 30 matching lines @@
   DeviceMap::iterator it = devices_.find(device_id);
   if (it != devices_.end())
     devices_.erase(it);
 }
 
 const HidService::DeviceMap& HidService::GetDevicesNoEnumerate() const {
   return devices_;
 }
 
 }  // namespace device