Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/extensions/api/chrome_extensions_api_client.cc

Issue 464753002: Fix HidService lifetime issues. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/chrome_extensions_api_client.h" 5 #include "chrome/browser/extensions/api/chrome_extensions_api_client.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "chrome/browser/extensions/api/storage/sync_value_store_cache.h" 8 #include "chrome/browser/extensions/api/storage/sync_value_store_cache.h"
9 #include "chrome/browser/guest_view/app_view/app_view_guest.h" 9 #include "chrome/browser/guest_view/app_view/app_view_guest.h"
10 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h" 10 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h"
11 #include "chrome/browser/guest_view/web_view/web_view_guest.h" 11 #include "chrome/browser/guest_view/web_view/web_view_guest.h"
12 #include "content/public/browser/browser_context.h" 12 #include "content/public/browser/browser_context.h"
13 #include "content/public/browser/browser_thread.h" 13 #include "content/public/browser/browser_thread.h"
14 #include "device/hid/hid_service.h"
15 14
16 #if defined(ENABLE_CONFIGURATION_POLICY) 15 #if defined(ENABLE_CONFIGURATION_POLICY)
17 #include "chrome/browser/extensions/api/storage/managed_value_store_cache.h" 16 #include "chrome/browser/extensions/api/storage/managed_value_store_cache.h"
18 #endif 17 #endif
19 18
20 namespace extensions { 19 namespace extensions {
21 20
22 ChromeExtensionsAPIClient::ChromeExtensionsAPIClient() {} 21 ChromeExtensionsAPIClient::ChromeExtensionsAPIClient() {}
23 22
24 ChromeExtensionsAPIClient::~ChromeExtensionsAPIClient() {} 23 ChromeExtensionsAPIClient::~ChromeExtensionsAPIClient() {}
(...skipping 28 matching lines...) Expand all
53 bool ChromeExtensionsAPIClient::AppViewInternalDenyRequest( 52 bool ChromeExtensionsAPIClient::AppViewInternalDenyRequest(
54 content::BrowserContext* browser_context, 53 content::BrowserContext* browser_context,
55 int guest_instance_id, 54 int guest_instance_id,
56 const std::string& guest_extension_id) { 55 const std::string& guest_extension_id) {
57 return AppViewGuest::CompletePendingRequest(browser_context, 56 return AppViewGuest::CompletePendingRequest(browser_context,
58 GURL(), 57 GURL(),
59 guest_instance_id, 58 guest_instance_id,
60 guest_extension_id); 59 guest_extension_id);
61 } 60 }
62 61
63 device::HidService* ChromeExtensionsAPIClient::GetHidService() {
64 if (!hid_service_) {
65 hid_service_.reset(device::HidService::Create(
66 content::BrowserThread::GetMessageLoopProxyForThread(
67 content::BrowserThread::UI)));
68 }
69 return hid_service_.get();
70 }
71
72 void ChromeExtensionsAPIClient::RegisterGuestViewTypes() { 62 void ChromeExtensionsAPIClient::RegisterGuestViewTypes() {
73 AppViewGuest::Register(); 63 AppViewGuest::Register();
74 ExtensionOptionsGuest::Register(); 64 ExtensionOptionsGuest::Register();
75 WebViewGuest::Register(); 65 WebViewGuest::Register();
76 } 66 }
77 67
78 } // namespace extensions 68 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698