chrome/browser/resources/options/deletable_item_list.js - Issue 464703002: Fixed a11y tab-handling for language settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/deletable_item_list.js

Issue 464703002: Fixed a11y tab-handling for language settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes based on feedback from dbeam@ Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/deletable_item_list.js

diff --git a/chrome/browser/resources/options/deletable_item_list.js b/chrome/browser/resources/options/deletable_item_list.js

index 5522a782ce73c720bd9d9764a9cde562ca3cd5d4..7b5cd03ffca5f58252445ddf81b5d77deeb59eec 100644

--- a/chrome/browser/resources/options/deletable_item_list.js

+++ b/chrome/browser/resources/options/deletable_item_list.js

@@ -54,6 +54,7 @@ cr.define('options', function() {

this.handleMouseDownUpOnClose_);

this.closeButtonElement_.addEventListener('focus',

this.handleFocus_.bind(this));

+ this.closeButtonElement_.tabIndex = -1;

this.closeButtonElement_.title =

loadTimeData.getString('deletableItemDeleteButtonTitle');

this.appendChild(this.closeButtonElement_);

« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/language_options_interactive_uitest.cc » ('j') | no next file with comments »