Fixed a11y tab-handling for language settings

chrome/browser/ui/webui/options/language_options_interactive_uitest.cc

Index: chrome/browser/ui/webui/options/language_options_interactive_uitest.cc
diff --git a/chrome/browser/ui/webui/options/language_options_interactive_uitest.cc b/chrome/browser/ui/webui/options/language_options_interactive_uitest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..efda5ba99dbcce30f63bd057e707af9eab64e0ad
--- /dev/null
+++ b/chrome/browser/ui/webui/options/language_options_interactive_uitest.cc
@@ -0,0 +1,140 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/prefs/pref_service.h"
+#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/common/url_constants.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/interactive_test_utils.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace language_options_ui_test {
+
+namespace {
+
+// This class will test the language options settings.
+// We need to emulate button pushing because we are testing accessibility,

[groby-ooo-7-16, 2014/08/18 21:42:04]

Nit: avoid "we", "I" in comments - they're often unclear. 

[hcarmona, 2014/08/18 23:39:51]

Done.

+// this means that this is part of interactive_ui_tests.
+class LanguageOptionsWebUITest : public InProcessBrowserTest {
+ public:
+  LanguageOptionsWebUITest() {}
+
+  // This method will navigate to the language settings page and show
+  // a subset of languages from the list of available languages.
+  virtual void SetUpOnMainThread() OVERRIDE {
+  // This constant is different for Chrome OS and everything else

[groby-ooo-7-16, 2014/08/18 21:42:05]

nit: no need to spell that out - the code gives it away :)

[hcarmona, 2014/08/18 23:39:51]

Done.

+#ifdef OS_CHROMEOS

[groby-ooo-7-16, 2014/08/18 21:42:05]

nit: #if defined(OS_CHROMEOS)

+    auto setting_name = prefs::kLanguagePreferredLanguages;
+#else
+    auto setting_name = prefs::kAcceptLanguages;

[groby-ooo-7-16, 2014/08/18 21:42:04]

This bugs me. Do you know _why_ they're different?

[hcarmona, 2014/08/18 23:39:51]

Not sure why they're different. It may have to do with Chrome OS having more
settings for languages than other OSs.

On 2014/08/18 21:42:04, groby wrote:

+#endif
+
+    const GURL url = chrome::GetSettingsUrl(chrome::kLanguageOptionsSubPage);
+    ui_test_utils::NavigateToURL(browser(), url);
+    browser()->profile()->GetPrefs()->SetString(setting_name, "en-US,es,fr");
+  }
+
+ protected:
+  // Will get the id of the element in the UI that has focus.
+  std::string GetActiveElementId() {
+    std::string get_element_id_script =
+        "domAutomationController.send(document.activeElement.id);";
+    std::string element_id;
+    EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+          GetActiveFrame(),
+          get_element_id_script,
+          &element_id));
+    return element_id;
+  }
+
+  content::RenderFrameHost* GetActiveFrame() {
+    return GetActiveWebContents()->GetFocusedFrame();
+  }
+
+  content::WebContents* GetActiveWebContents() {
+    return browser()->tab_strip_model()->GetActiveWebContents();
+  }
+
+  // Press and release a key in a particular window. Returns false on error.
+  bool PressKey(ui::KeyboardCode key_code) {
+    return ui_test_utils::SendKeyPressSync(browser(), key_code,
+                                           false, false, false, false);
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(LanguageOptionsWebUITest);
+};
+
+}  // namespace
+
+// This test will verify that the appropriate languages are available.
+// This test will also fail if the language page is not loaded because a random
+// page will not have the language list.
+// Test assumes that the default active element is the list of languages.
+IN_PROC_BROWSER_TEST_F(LanguageOptionsWebUITest, TestAvailableLanguages) {
+  // Verify that the language list is focused by default.
+  std::string original_id = GetActiveElementId();
+  EXPECT_EQ("language-options-list", original_id);
+
+  content::RenderFrameHost* active_frame = GetActiveFrame();
+
+  std::string count_deletable_items_script =
+    "var count = 0;"

[groby-ooo-7-16, 2014/08/18 21:42:04]

Why not querySelectorAll?

I.e. document.activeElement.querySelectorAll('.deletable-item').length;

[hcarmona, 2014/08/18 23:39:51]

Did not know about querySelectorAll, updated code to take advantage of this.

On 2014/08/18 21:42:04, groby wrote:

+    "for (var i = 0; i < document.activeElement.childElementCount; ++i) {"
+    "  if (document.activeElement.children[i].className == 'deletable-item')"
+    "    ++count;"
+    "}"
+    "domAutomationController.send(count);";
+
+  // Count the number of languages in the list.
+  int language_count = 0;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractInt(
+      active_frame,
+      count_deletable_items_script,
+      &language_count));
+  EXPECT_EQ(3, language_count);
+
+  std::string get_children_of_current_element_script =
+      "domAutomationController.send(document.activeElement.textContent);";
+
+
+  // Verify that the correct languages are added to the list.
+  std::string languages = "";
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      active_frame,
+      get_children_of_current_element_script,
+      &languages));
+  EXPECT_EQ("English (United States)SpanishFrench", languages);
+}
+
+// This test will validate that the language webui is accessible through
+// the keyboard.
+// This test must be updated if the tab order of the elements on this page
+// is chagned.
+IN_PROC_BROWSER_TEST_F(LanguageOptionsWebUITest, TestListTabAccessibility) {
+  // Verify that the language list is focused by default.
+  std::string original_id = GetActiveElementId();
+  EXPECT_EQ("language-options-list", original_id);
+
+  // Press tab to select the next element.
+  EXPECT_TRUE(PressKey(ui::VKEY_TAB));
+
+  // Make sure that the element is now the button that is next in the tab order.
+  // Checking that the list is not selected is not sufficient to validate this
+  // use case because we will still want to have a failure if an item inside the
+  // list is selected.
+  std::string new_id = GetActiveElementId();
+  EXPECT_EQ("language-options-add-button", new_id);
+}
+
+}  // namespace language_options_ui_test
+