Fixed a11y tab-handling for language settings

chrome/browser/ui/webui/options/language_options_interactive_uitest.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/prefs/pref_service.h"
+#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/common/url_constants.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/interactive_test_utils.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace language_options_ui_test {
+
+namespace {
+
+// This class will test the language options settings.
+// This test is part of the interactive_ui_tests isntead of browser_tests
+// because it is necessary to emulate pushing a button in order to properly
+// test accessiblity.
+class LanguageOptionsWebUITest : public InProcessBrowserTest {
+ public:
+  LanguageOptionsWebUITest() {}
+
+  // This method will navigate to the language settings page and show
+  // a subset of languages from the list of available languages.
+  virtual void SetUpOnMainThread() OVERRIDE {
+#if defined(OS_CHROMEOS)
+    auto setting_name = prefs::kLanguagePreferredLanguages;
+#else
+    auto setting_name = prefs::kAcceptLanguages;
+#endif
+
+    const GURL url = chrome::GetSettingsUrl(chrome::kLanguageOptionsSubPage);
+    ui_test_utils::NavigateToURL(browser(), url);
+    browser()->profile()->GetPrefs()->SetString(setting_name, "en-US,es,fr");
+  }
+
+ protected:
+  // Will get the id of the element in the UI that has focus.
+  std::string GetActiveElementId() {
+    std::string get_element_id_script =
+        "domAutomationController.send(document.activeElement.id);";
+    std::string element_id;
+    EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+          GetActiveFrame(),
+          get_element_id_script,
+          &element_id));
+    return element_id;
+  }
+
+  content::RenderFrameHost* GetActiveFrame() {
+    return GetActiveWebContents()->GetFocusedFrame();
+  }
+
+  content::WebContents* GetActiveWebContents() {
+    return browser()->tab_strip_model()->GetActiveWebContents();
+  }
+
+  // Press and release a key in a particular window. Returns false on error.
+  bool PressKey(ui::KeyboardCode key_code) {
+    return ui_test_utils::SendKeyPressSync(browser(), key_code,
+                                           false, false, false, false);
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(LanguageOptionsWebUITest);
+};
+
+}  // namespace
+
+// This test will verify that the appropriate languages are available.
+// This test will also fail if the language page is not loaded because a random
+// page will not have the language list.
+// Test assumes that the default active element is the list of languages.
+IN_PROC_BROWSER_TEST_F(LanguageOptionsWebUITest, TestAvailableLanguages) {
+  // Verify that the language list is focused by default.
+  std::string original_id = GetActiveElementId();
+  EXPECT_EQ("language-options-list", original_id);
+
+  content::RenderFrameHost* active_frame = GetActiveFrame();

[Dan Beam, 2014/08/19 00:06:37]

ASSERT_TRUE(active_frame);

[hcarmona, 2014/08/19 00:36:52]

Not changed because test would have crashed by this point if it was not possible
to get the active frame. 

On 2014/08/19 00:06:37, Dan Beam wrote:

+
+  std::string count_deletable_items_script =
+    "domAutomationController.send("
+    "    document.activeElement.querySelectorAll('.deletable-item').length);";
+
+  // Count the number of languages in the list.
+  int language_count = 0;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractInt(

[Dan Beam, 2014/08/19 00:06:37]

nit: ASSERT_TRUE()

[hcarmona, 2014/08/19 00:36:52]

Done.

+      active_frame,
+      count_deletable_items_script,
+      &language_count));
+  EXPECT_EQ(3, language_count);
+
+  std::string get_children_of_current_element_script =
+      "domAutomationController.send(document.activeElement.textContent);";
+
+

[Dan Beam, 2014/08/19 00:06:37]

nit: remove 1 \n

[hcarmona, 2014/08/19 00:36:52]

Done.

+  // Verify that the correct languages are added to the list.
+  std::string languages = "";

[Dan Beam, 2014/08/19 00:06:37]

nit: just

  std::string languages;

[hcarmona, 2014/08/19 00:36:52]

Done.

+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      active_frame,
+      get_children_of_current_element_script,
+      &languages));
+  EXPECT_EQ("English (United States)SpanishFrench", languages);
+}
+
+// This test will validate that the language webui is accessible through
+// the keyboard.
+// This test must be updated if the tab order of the elements on this page
+// is chagned.
+IN_PROC_BROWSER_TEST_F(LanguageOptionsWebUITest, TestListTabAccessibility) {
+  // Verify that the language list is focused by default.
+  std::string original_id = GetActiveElementId();
+  EXPECT_EQ("language-options-list", original_id);
+
+  // Press tab to select the next element.
+  EXPECT_TRUE(PressKey(ui::VKEY_TAB));

[Dan Beam, 2014/08/19 00:06:37]

nit: ASSERT_TRUE()

[hcarmona, 2014/08/19 00:36:52]

Done.

+
+  // Make sure that the element is now the button that is next in the tab order.
+  // Checking that the list is no longer selected is not sufficient to validate
+  // this use case because this test should fail if an item inside the list is
+  // selected.
+  std::string new_id = GetActiveElementId();
+  EXPECT_EQ("language-options-add-button", new_id);
+}
+
+}  // namespace language_options_ui_test
+