Issue 464673002: Revert 288817 "[Mac, Win] Only show the user manager tutorial if..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464673002: Revert 288817 "[Mac, Win] Only show the user manager tutorial if..." (Closed)

Created:
6 years, 4 months ago by luken

Modified:
6 years, 4 months ago

Reviewers:
noms (inactive)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 288817 "[Mac, Win] Only show the user manager tutorial if..." > [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked. > > - remove the profile preference that used to keep track of showing the > tutorial any time the user manager was shown for a particular profile. > > - show the upgrade bubble for local profiles as well (so that local profiles > have a chance to see the tutorial) > > - for the local profiles upgrade bubble, don't show the "Not you?" link as > it doesn't really make sense. > > BUG=399679 > TBR=rpetterson@chromium.org > > Review URL: https://codereview.chromium.org/454153002 TBR=noms@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288828

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -53 lines)			Patch
M	trunk/src/chrome/browser/profiles/profile.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/profiles/profile_window.cc	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm	View	8 chunks	+29 lines, -22 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/profiles/profile_chooser_view.cc	View	6 chunks	+15 lines, -21 lines	0 comments	Download
M	trunk/src/chrome/common/pref_names.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/common/pref_names.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

luken

6 years, 4 months ago (2014-08-11 23:39:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r288828 (tree was closed).

Expand Messages | Collapse Messages