Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2503)

Unified Diff: content/renderer/pepper/v8object_var.h

Issue 464653003: Change V8ObjectVar to store a pointer to the instance rather than an ID (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/pepper/v8object_var.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/v8object_var.h
diff --git a/content/renderer/pepper/v8object_var.h b/content/renderer/pepper/v8object_var.h
index 7f5dfd32a8e399760d5cd45d80ee02afe4411514..9c492a24b6aede83106215510da4130a52012bbb 100644
--- a/content/renderer/pepper/v8object_var.h
+++ b/content/renderer/pepper/v8object_var.h
@@ -13,6 +13,10 @@
#include "ppapi/shared_impl/var.h"
#include "v8/include/v8.h"
+namespace content {
+class PepperPluginInstanceImpl;
+} // namespace content
+
namespace ppapi {
// V8ObjectVar -----------------------------------------------------------------
@@ -41,7 +45,7 @@ class V8ObjectVar : public Var {
void InstanceDeleted();
// Possibly 0 if the object has outlived its instance.
Sam McNally 2014/08/12 01:44:05 s/0/NULL/
raymes 2014/08/12 03:09:08 Done.
- PP_Instance instance() const { return instance_; }
+ content::PepperPluginInstanceImpl* instance() const { return instance_; }
// Helper function that converts a PP_Var to an object. This will return NULL
// if the PP_Var is not of object type or the object is invalid.
@@ -50,7 +54,7 @@ class V8ObjectVar : public Var {
private:
virtual ~V8ObjectVar();
- PP_Instance instance_;
+ content::PepperPluginInstanceImpl* instance_;
v8::Persistent<v8::Object> v8_object_;
« no previous file with comments | « no previous file | content/renderer/pepper/v8object_var.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698