Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 464653003: Change V8ObjectVar to store a pointer to the instance rather than an ID (Closed)

Created:
6 years, 4 months ago by raymes
Modified:
6 years, 4 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org, dmichael (off chromium)
Project:
chromium
Visibility:
Public.

Description

Change V8ObjectVar to store a pointer to the instance rather than an ID This changes the currently unused V8ObjectVar to store a pointer to the instance rather than a PP_Instance ID. This is just more convenient for the code which uses the V8ObjectVar. When the instance is deleted, the pointer will be cleared so it should always be valid or NULL. BUG=351636 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289191

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M content/renderer/pepper/v8object_var.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/pepper/v8object_var.cc View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
raymes
6 years, 4 months ago (2014-08-12 01:19:36 UTC) #1
Sam McNally
LGTM https://codereview.chromium.org/464653003/diff/1/content/renderer/pepper/v8object_var.h File content/renderer/pepper/v8object_var.h (right): https://codereview.chromium.org/464653003/diff/1/content/renderer/pepper/v8object_var.h#newcode47 content/renderer/pepper/v8object_var.h:47: // Possibly 0 if the object has outlived ...
6 years, 4 months ago (2014-08-12 01:44:05 UTC) #2
raymes
https://codereview.chromium.org/464653003/diff/1/content/renderer/pepper/v8object_var.h File content/renderer/pepper/v8object_var.h (right): https://codereview.chromium.org/464653003/diff/1/content/renderer/pepper/v8object_var.h#newcode47 content/renderer/pepper/v8object_var.h:47: // Possibly 0 if the object has outlived its ...
6 years, 4 months ago (2014-08-12 03:09:09 UTC) #3
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 4 months ago (2014-08-12 03:09:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/464653003/20001
6 years, 4 months ago (2014-08-12 03:12:11 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 05:30:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 08:08:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/5769)
6 years, 4 months ago (2014-08-12 08:08:17 UTC) #8
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 4 months ago (2014-08-13 00:20:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/464653003/20001
6 years, 4 months ago (2014-08-13 00:46:39 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 03:47:33 UTC) #11
Message was sent while issue was closed.
Change committed as 289191

Powered by Google App Engine
This is Rietveld 408576698