[Resources] Use the correct orientation for avatars in the new-avatar-menu world.

[Resources] Use the correct orientation for avatars in the new-avatar-menu world.

We are planning on turning on --enable-new-avatar-menu by default in M38. In this
brave new world, the avatar button is always in the top right corner of the browser,
for all platforms. Previously, on Windows this button lived on the left side.

To make sure that the new world is the one that looks the best, we should always
use the correct orientation for the avatars. This does mean that for people
with the flag turned off, that are using the old style avatar menu on Windows,
they will see the avatars mirror.

BUG=380611
TEST=Start Chrome on Windows with --enable-new-avatar-menu. The avatar in the
avatar bubble should have the same orientation as in chrome://settings.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289522

[noms (inactive), 2014-08-11 21:55:00]

Hiya,

I'm picking you as reviewers because I think you might have strong opinions
about this. Basically, the position of the avatar button on Windows is changing,
which means that the orientation of the avatar images needs to change as well.

However, since they're resources, they can only have one orientation per build.
This means that if the "after we've enabled the new avatar menu" state looks
nice on Windows, the "before we've enabled the new avatar menu" state doesn't.
We're ok with this, but I want to make sure you are too.

(this is explained in more details in the CL description and the crbug)

Please take a look. Thanks!

[sky, 2014-08-11 23:51:03]

If you do this, and then someone decides that don't like the new for 38 doesn't
it mean you need to do more than just changing the default value of the switch?

[noms (inactive), 2014-08-12 01:09:07]

If they decided they don't like the new stuff, they'd still have their old
school avatar button, but with the icons mirrored. So, a regression bug. In the
worst case this could affect all our 4% users of multi profiles. Since we're
turning the new stuff to all users though, this is why we tried to make the new
experience the correct one.

I could add an ifdef that for Windows, for the old avatar button, to
programmatically mirror the image, but I don't have any intuition about the
performance implications of this. Do you think it would be feasible/worth it?

On 2014/08/11 23:51:03, sky wrote:
> If you do this, and then someone decides that don't like the new for 38
doesn't
> it mean you need to do more than just changing the default value of the
switch?

[sky, 2014-08-12 02:28:50]

I guess we deal with it if we need to disable. LGTM

[noms (inactive), 2014-08-13 16:44:01]

Mitsuru, are you ok with this plan? Can I go ahead and land it?

[oshima, 2014-08-13 18:36:19]

On 2014/08/13 16:44:01, Monica Dinculescu wrote:
> Mitsuru, are you ok with this plan? Can I go ahead and land it?

lgtm

just make sure to clean up when the decision is made (if necessary).

[noms (inactive), 2014-08-13 18:56:42]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-08-13 19:02:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noms@chromium.org/464603002/80001

[commit-bot: I haz the power, 2014-08-14 07:32:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-14 11:16:33]

Committed patchset #4 (80001) as 289522