chrome/browser/ui/views/constrained_window_views.cc - Issue 464533002: Move guest_view to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/constrained_window_views.cc

Issue 464533002: Move guest_view to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small changes are made in guest_view_manager_unittest.cc Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/constrained_window_views.cc

diff --git a/chrome/browser/ui/views/constrained_window_views.cc b/chrome/browser/ui/views/constrained_window_views.cc

index 86f1ec7feabb904c60fe23b2a07a19ab8ad507d5..c95f31b931227cdf1ef8752cecd6fde4436b9864 100644

--- a/chrome/browser/ui/views/constrained_window_views.cc

+++ b/chrome/browser/ui/views/constrained_window_views.cc

@@ -123,8 +123,8 @@ void UpdateBrowserModalDialogPosition(views::Widget* widget,

views::Widget* ShowWebModalDialogViews(

views::WidgetDelegate* dialog,

content::WebContents* initiator_web_contents) {

- WebViewGuest* web_view_guest = WebViewGuest::FromWebContents(

- initiator_web_contents);

+ extensions::WebViewGuest* web_view_guest =

+ extensions::WebViewGuest::FromWebContents(initiator_web_contents);

// For embedded WebContents, use the embedder's WebContents for constrained

// window.

content::WebContents* web_contents =