chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm - Issue 464533002: Move guest_view to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

Issue 464533002: Move guest_view to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small changes are made in guest_view_manager_unittest.cc Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

index 8fcdeebe8f7d36d0199b76ebf6bc469fbf9e76d9..ab7989be521f0d75f5fbf49dcfee2cac4110397c 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

@@ -28,7 +28,8 @@ ConstrainedWindowMac::ConstrainedWindowMac(

sheet_([sheet retain]),

shown_(false) {

DCHECK(web_contents);

- WebViewGuest* web_view_guest = WebViewGuest::FromWebContents(web_contents);

+ extensions::WebViewGuest* web_view_guest =

+ extensions::WebViewGuest::FromWebContents(web_contents);

// For embedded WebContents, use the embedder's WebContents for constrained

// window.

web_contents_ = web_view_guest && web_view_guest->embedder_web_contents() ?

« no previous file with comments | « chrome/browser/task_manager/extension_information.cc ('k') | chrome/browser/ui/views/constrained_window_views.cc » ('j') | no next file with comments »