chrome/browser/guest_view/web_view/javascript_dialog_helper.cc - Issue 464533002: Move guest_view to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 464533002: Move guest_view to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small changes are made in guest_view_manager_unittest.cc Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/guest_view/web_view/javascript_dialog_helper.cc

diff --git a/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc b/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc

index c6dc2f62443cea4af6329e05dcc9e03458e8abdd..6fe90b1b4f45c78269151998d03e549e4372210a 100644

--- a/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc

+++ b/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc

@@ -12,6 +12,8 @@

#include "chrome/browser/guest_view/web_view/web_view_permission_types.h"

#include "extensions/browser/guest_view/guest_view_constants.h"

+namespace extensions {

namespace {

std::string JavaScriptMessageTypeToString(

@@ -100,3 +102,5 @@ void JavaScriptDialogHelper::OnPermissionResponse(

callback.Run(allow && web_view_guest_->attached(),

base::UTF8ToUTF16(user_input));

}

+} // namespace extensions