Move guest_view to extensions.

Move guest_view to extensions.

1. Update guest_view_manager_unittest.cc.
2. Move guest_view code to extensions.
3. Add namespace extensions for classes within guest_view/web_view/app_view.

BUG=352290
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289030

[Fady Samuel, 2014-08-11 19:48:50]

lgtm

[Fady Samuel, 2014-08-11 19:51:51]

https://codereview.chromium.org/464533002/diff/40001/chrome/browser/apps/web_...
File chrome/browser/apps/web_view_interactive_browsertest.cc (right):

https://codereview.chromium.org/464533002/diff/40001/chrome/browser/apps/web_...
chrome/browser/apps/web_view_interactive_browsertest.cc:104:
extensions::GuestViewManager::set_factory_for_testing(&factory_);
nit: spacing

[Fady Samuel, 2014-08-11 19:51:51]

https://codereview.chromium.org/464533002/diff/40001/chrome/browser/apps/web_...
File chrome/browser/apps/web_view_interactive_browsertest.cc (right):

https://codereview.chromium.org/464533002/diff/40001/chrome/browser/apps/web_...
chrome/browser/apps/web_view_interactive_browsertest.cc:104:
extensions::GuestViewManager::set_factory_for_testing(&factory_);
nit: spacing

[Xi Han, 2014-08-11 20:06:14]

Ken: Please review changes in:
-chrome/browser/extensions/api/identity/identity_apitest.cc
-chrome/browser/extensions/api/identity/web_auth_flow.cc
-chrome/browser/extensions/api/web_request/web_request_api.cc
-chrome/browser/extensions/api/web_request/web_request_permissions.cc
-chrome/browser/geolocation/geolocation_permission_context_extensions.cc
-extensions/extensions.gyp

Thanks!

https://codereview.chromium.org/464533002/diff/40001/chrome/browser/apps/web_...
File chrome/browser/apps/web_view_interactive_browsertest.cc (right):

https://codereview.chromium.org/464533002/diff/40001/chrome/browser/apps/web_...
chrome/browser/apps/web_view_interactive_browsertest.cc:104:
extensions::GuestViewManager::set_factory_for_testing(&factory_);
On 2014/08/11 19:51:51, Fady Samuel wrote:
> nit: spacing

Done.

[Xi Han, 2014-08-11 20:51:56]

James: Please review changes in:
- extensions/browser/DEPS

Thanks!

[James Cook, 2014-08-11 21:13:01]

extensions/browser/DEPS lgtm

[Ken Rockot(use gerrit already), 2014-08-11 21:25:00]

This looks great.

One general change though: I think that, moving forward, we would like to see
the extensions namespace in use only be code which lives in //extensions.

Ideally, //chrome extensions implementation details would not live in the
extensions namespace. They could in theory live in chrome::extensions::, but I
think that's probably overkill and would opt for no namespace at all.

Can you please undo the addition of the extensions namespace to code which still
lives in //chrome?

https://codereview.chromium.org/464533002/diff/60001/extensions/browser/guest...
File extensions/browser/guest_view/guest_view_manager_unittest.cc (right):

https://codereview.chromium.org/464533002/diff/60001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_manager_unittest.cc:58:
content::TestBrowserContext profile_;
nit: Rename profile_ to browser_context_?

https://codereview.chromium.org/464533002/diff/60001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_manager_unittest.cc:66:
content::TestBrowserContext profile;
nit: Rename profile -> browser_context?

[Ken Rockot(use gerrit already), 2014-08-11 21:27:58]

On 2014/08/11 21:25:00, Ken Rockot wrote:
> This looks great.
> 
> One general change though: I think that, moving forward, we would like to see
> the extensions namespace in use only be code which lives in //extensions.
> 
> Ideally, //chrome extensions implementation details would not live in the
> extensions namespace. They could in theory live in chrome::extensions::, but I
> think that's probably overkill and would opt for no namespace at all.
> 
> Can you please undo the addition of the extensions namespace to code which
still
> lives in //chrome?
> 
>
https://codereview.chromium.org/464533002/diff/60001/extensions/browser/guest...
> File extensions/browser/guest_view/guest_view_manager_unittest.cc (right):
> 
>
https://codereview.chromium.org/464533002/diff/60001/extensions/browser/guest...
> extensions/browser/guest_view/guest_view_manager_unittest.cc:58:
> content::TestBrowserContext profile_;
> nit: Rename profile_ to browser_context_?
> 
>
https://codereview.chromium.org/464533002/diff/60001/extensions/browser/guest...
> extensions/browser/guest_view/guest_view_manager_unittest.cc:66:
> content::TestBrowserContext profile;
> nit: Rename profile -> browser_context?

chatted out of thread - the chrome code is eventually going to move anyway, so
no sense in undoing the namespace change. lgtm

[Xi Han, 2014-08-11 21:38:11]

Hi John: Please review changes in:
-chrome/browser/apps/app_view_browsertest.cc
-chrome/browser/devtools/devtools_target_impl.cc
-chrome/browser/geolocation/geolocation_permission_context_extensions.cc
-chrome/browser/plugins/plugin_info_message_filter.cc
-chrome/browser/prerender/prerender_link_manager.cc
-chrome/browser/profiles/off_the_record_profile_impl.cc
-chrome/browser/profiles/profile_impl.cc
-chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc
-chrome/browser/renderer_context_menu/render_view_context_menu.cc
-chrome/browser/renderer_host/chrome_render_message_filter.cc
-chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
-chrome/browser/task_manager/extension_information.cc
-chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm
-chrome/browser/ui/views/constrained_window_views.cc
-chrome/test/base/testing_profile.cc

The change list seems long, but most of the changes are just "include" and
namespace changes.

Thanks!

https://codereview.chromium.org/464533002/diff/60001/extensions/browser/guest...
File extensions/browser/guest_view/guest_view_manager_unittest.cc (right):

https://codereview.chromium.org/464533002/diff/60001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_manager_unittest.cc:58:
content::TestBrowserContext profile_;
On 2014/08/11 21:25:00, Ken Rockot wrote:
> nit: Rename profile_ to browser_context_?

Done.

https://codereview.chromium.org/464533002/diff/60001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_manager_unittest.cc:66:
content::TestBrowserContext profile;
On 2014/08/11 21:25:00, Ken Rockot wrote:
> nit: Rename profile -> browser_context?

Done.

[Xi Han, 2014-08-12 13:10:52]

Hi Jochen: Please review changes in:
-chrome/browser/apps/app_view_browsertest.cc
-chrome/browser/devtools/devtools_target_impl.cc
-chrome/browser/geolocation/geolocation_permission_context_extensions.cc
-chrome/browser/plugins/plugin_info_message_filter.cc
-chrome/browser/prerender/prerender_link_manager.cc
-chrome/browser/profiles/off_the_record_profile_impl.cc
-chrome/browser/profiles/profile_impl.cc
-chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc
-chrome/browser/renderer_context_menu/render_view_context_menu.cc
-chrome/browser/renderer_host/chrome_render_message_filter.cc
-chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
-chrome/browser/task_manager/extension_information.cc
-chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm
-chrome/browser/ui/views/constrained_window_views.cc
-chrome/test/base/testing_profile.cc

The change list seems long, but most of the changes are just "include" and
namespace changes.

Thanks!

[jochen (gone - plz use gerrit), 2014-08-12 14:50:05]

rubberstamp lgtm

[Xi Han, 2014-08-12 14:50:50]

The CQ bit was checked by hanxi@chromium.org

[commit-bot: I haz the power, 2014-08-12 14:53:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hanxi@chromium.org/464533002/80001

[commit-bot: I haz the power, 2014-08-12 18:26:53]

Change committed as 289030