Issue 464483002: [Local NTP] Fix LocalNTP tests, and re-enable them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464483002: [Local NTP] Fix LocalNTP tests, and re-enable them. (Closed)

Created:
6 years, 4 months ago by Mathieu

Modified:
6 years, 4 months ago

Reviewers:
Jered

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Local NTP] Fix LocalNTP tests, and re-enable them. BUG=267117 TEST=LocalNTPTest (interactive_ui_tests) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289321

Patch Set 1 #

Patch Set 2 : abort test if platform doesn't support locale #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	chrome/browser/ui/search/instant_test_utils.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/search/local_ntp_browsertest.cc	View	1	3 chunks	+10 lines, -6 lines	0 comments	Download