Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 464473002: Add "own" symbols support. (Closed)

Created:
6 years, 4 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add "own" symbols support. "Own" symbols are symbols that can only denote own properties of objects. R=hpayer@chromium.org, verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23056 Committed: https://code.google.com/p/v8/source/detail?r=23083

Patch Set 1 #

Patch Set 2 : Minor fixes #

Total comments: 1

Patch Set 3 : Patch for landing #

Patch Set 4 : Fixes for 64-bit builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -8 lines) Patch
M src/factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.h View 1 2 3 chunks +11 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A test/mjsunit/own-symbols.js View 1 chunk +55 lines, -0 lines 0 comments Download
A + test/mjsunit/runtime-gen/createprivateownsymbol.js View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/generate-runtime-tests.py View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Dmitry Lomov (no reviews)
PTAL. I _hope_ I cover all of "old-style" lookup, let me know if I missed ...
6 years, 4 months ago (2014-08-11 15:14:01 UTC) #1
Toon Verwaest
lgtm
6 years, 4 months ago (2014-08-11 15:56:30 UTC) #2
Dmitry Lomov (no reviews)
https://codereview.chromium.org/464473002/diff/20001/src/lookup.h File src/lookup.h (right): https://codereview.chromium.org/464473002/diff/20001/src/lookup.h#newcode193 src/lookup.h:193: return static_cast<Configuration>(configuration && CHECK_OWN); Oh noes this '&&' is ...
6 years, 4 months ago (2014-08-11 16:06:41 UTC) #3
arv (Not doing code reviews)
I don't think there is a single case (today) where we want a private symbol ...
6 years, 4 months ago (2014-08-11 16:20:18 UTC) #4
Dmitry Lomov (no reviews)
On 2014/08/11 16:20:18, arv wrote: > I don't think there is a single case (today) ...
6 years, 4 months ago (2014-08-11 16:27:30 UTC) #5
Dmitry Lomov (no reviews)
Committed patchset #3 manually as 23056 (presubmit successful).
6 years, 4 months ago (2014-08-11 18:59:55 UTC) #6
Dmitry Lomov (no reviews)
Adding Hannes for heap.cc change. We now pretenure runtime functions list so that GC tests ...
6 years, 4 months ago (2014-08-12 14:38:22 UTC) #7
Hannes Payer (out of office)
lgtm
6 years, 4 months ago (2014-08-12 15:24:00 UTC) #8
Dmitry Lomov (no reviews)
Committed patchset #4 manually as 23083 (presubmit successful).
6 years, 4 months ago (2014-08-12 15:28:40 UTC) #9
Dmitry Lomov (no reviews)
On 2014/08/11 16:20:18, arv wrote: > I don't think there is a single case (today) ...
6 years, 4 months ago (2014-08-18 13:38:09 UTC) #10
Toon Verwaest
I'm pretty sure we don't care whether that particular case is "own" or not. Adding ...
6 years, 4 months ago (2014-08-18 14:20:58 UTC) #11
Yang
6 years, 4 months ago (2014-08-18 14:23:35 UTC) #12
Message was sent while issue was closed.
On 2014/08/18 14:20:58, Toon Verwaest wrote:
> I'm pretty sure we don't care whether that particular case is "own" or not.
> Adding Yang to be sure.

Yeah. I already talked to Dmitry about this. What we only want is to get the
private property off the holder of the getter, which is the Error object. We
iterate the prototype chain to find the holder anyways, so we could just get own
private property as well here.

Powered by Google App Engine
This is Rietveld 408576698