Chromium Code Reviews| Index: chrome/browser/metrics/extensions_metrics_provider.h |
| diff --git a/chrome/browser/metrics/extensions_metrics_provider.h b/chrome/browser/metrics/extensions_metrics_provider.h |
| index 6cca94dc30a5da87b50815a8fe7f554538573297..7653d8045cb1c7485a73184a46e287d6793edfe7 100644 |
| --- a/chrome/browser/metrics/extensions_metrics_provider.h |
| +++ b/chrome/browser/metrics/extensions_metrics_provider.h |
| @@ -35,8 +35,6 @@ class ExtensionsMetricsProvider : public metrics::MetricsProvider { |
| // metrics::MetricsProvider: |
|
Alexei Svitkine (slow)
2014/08/12 15:22:40
Nit: Remove this blank line.
jwd
2014/08/12 18:45:28
Done.
|
| - // Writes the hashed list of installed extensions into the specified |
| - // SystemProfileProto object. |
| virtual void ProvideSystemProfileMetrics( |
| metrics::SystemProfileProto* system_profile) OVERRIDE; |
| @@ -47,7 +45,8 @@ class ExtensionsMetricsProvider : public metrics::MetricsProvider { |
| // TODO(mvrable): If metrics are ever converted to being per-profile, then |
| // this should be updated to return extensions installed in a specified |
| // profile. |
| - virtual scoped_ptr<extensions::ExtensionSet> GetInstalledExtensions(); |
| + virtual scoped_ptr<extensions::ExtensionSet> GetInstalledExtensions( |
| + Profile* profile); |
| // Retrieves the client ID. |
| virtual uint64 GetClientID(); |
| @@ -63,12 +62,19 @@ class ExtensionsMetricsProvider : public metrics::MetricsProvider { |
| // same value so that reported extensions are consistent. |
| Profile* GetMetricsProfile(); |
| + // Writes whether any loaded profiles have extensions not from the webstore. |
| + void ProvideOffStoreMetric(metrics::SystemProfileProto* system_profile); |
| + |
| + // Writes the hashed list of installed extensions into the specified |
| + // SystemProfileProto object. |
| + void ProvideOccupiedBucketMetric(metrics::SystemProfileProto* system_profile); |
| + |
| // The MetricsStateManager from which the client ID is obtained. |
| metrics::MetricsStateManager* metrics_state_manager_; |
| - // The profile for which extensions are gathered. Once a profile is found |
| - // its value is cached here so that GetMetricsProfile() can return a |
| - // consistent value. |
| + // The profile for which extensions are gathered for the occupied bucket |
| + // metric. Once a profile is found its value is cached here so that |
| + // GetMetricsProfile() can return a consistent value. |
| Profile* cached_profile_; |
| DISALLOW_COPY_AND_ASSIGN(ExtensionsMetricsProvider); |