Adding logging of offstore extensions state to user metrics.

chrome/chrome_browser.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # All .cc, .h, .m, and .mm files under browser except for:
     # * tests and mocks.
     # * code below browser/chromeos
     # * code below browser/extensions
@@ skipping 704 matching lines @@
       'browser/memory_details_mac.cc',
       'browser/memory_details_win.cc',
       'browser/metrics/chrome_browser_main_extra_parts_metrics.cc',
       'browser/metrics/chrome_browser_main_extra_parts_metrics.h',
       'browser/metrics/chrome_metrics_service_accessor.cc',
       'browser/metrics/chrome_metrics_service_accessor.h',
       'browser/metrics/chrome_metrics_service_client.cc',
       'browser/metrics/chrome_metrics_service_client.h',
       'browser/metrics/chrome_stability_metrics_provider.cc',
       'browser/metrics/chrome_stability_metrics_provider.h',
-      'browser/metrics/extensions_metrics_provider.cc',
-      'browser/metrics/extensions_metrics_provider.h',
       'browser/metrics/field_trial_synchronizer.cc',
       'browser/metrics/field_trial_synchronizer.h',
       'browser/metrics/google_update_metrics_provider_win.cc',
       'browser/metrics/google_update_metrics_provider_win.h',
       'browser/metrics/gpu_metrics_provider.cc',
       'browser/metrics/gpu_metrics_provider.h',
       'browser/metrics/metric_event_duration_details.h',
       'browser/metrics/metrics_reporting_state.cc',
       'browser/metrics/metrics_reporting_state.h',
       'browser/metrics/metrics_service_accessor.cc',
@@ skipping 782 matching lines @@
       'browser/guest_view/web_view/web_view_find_helper.h',
       'browser/guest_view/web_view/web_view_guest.cc',
       'browser/guest_view/web_view/web_view_guest.h',
       'browser/guest_view/web_view/web_view_permission_types.h',
       'browser/guest_view/web_view/web_view_permission_helper.cc',
       'browser/guest_view/web_view/web_view_permission_helper.h',
       'browser/guest_view/web_view/web_view_renderer_state.cc',
       'browser/guest_view/web_view/web_view_renderer_state.h',
       'browser/infobars/infobar_extension_api.cc',
       'browser/infobars/infobar_extension_api.h',
+      'browser/metrics/extensions_metrics_provider.cc',
+      'browser/metrics/extensions_metrics_provider.h',

[Alexei Svitkine (slow), 2014/08/13 19:38:10]

Why is this moved all the way here?

[jwd, 2014/08/13 20:22:07]

I moved them here so that they only get compiled when extensions are enabled.

Alternate suggestions are welcome :)

[Alexei Svitkine (slow), 2014/08/13 20:30:30]

Ah, got it - I didn't realise it was in a different section. Makes sense.

       'browser/renderer_host/chrome_extension_message_filter.cc',
       'browser/renderer_host/chrome_extension_message_filter.h',
       'browser/safe_json_parser.cc',
       'browser/safe_json_parser.h',
       'browser/search/hotword_client.h',
       'browser/search/hotword_service.cc',
       'browser/search/hotword_service.h',
       'browser/search/hotword_service_factory.cc',
       'browser/search/hotword_service_factory.h',
       'browser/signin/easy_unlock_service.cc',
@@ skipping 2074 matching lines @@
             'package_name': 'org/chromium/chrome/browser',
             'template_deps': ['browser/android/tab_load_status.h'],
           },
           'includes': [ '../build/android/java_cpp_template.gypi' ],
         },
       ],
      },
     ],
   ],
 }