Adding logging of offstore extensions state to user metrics.

chrome/browser/metrics/extensions_metrics_provider.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_METRICS_EXTENSIONS_METRICS_PROVIDER_H_
 #define CHROME_BROWSER_METRICS_EXTENSIONS_METRICS_PROVIDER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 15 matching lines @@
 // reporting extension IDs with UMA reports (after hashing the extension IDs
 // for privacy).
 class ExtensionsMetricsProvider : public metrics::MetricsProvider {
  public:
   // Holds on to |metrics_state_manager|, which must outlive this object, as a
   // weak pointer.
   explicit ExtensionsMetricsProvider(
       metrics::MetricsStateManager* metrics_state_manager);
   virtual ~ExtensionsMetricsProvider();
 
-  // metrics::MetricsProvider:
-
-  // Writes the hashed list of installed extensions into the specified
-  // SystemProfileProto object.
   virtual void ProvideSystemProfileMetrics(

[Alexei Svitkine (slow), 2014/08/13 19:38:10]

Nit: Keep the comment (without any blank line right above this):

// metrics::MetricsProvider:

[jwd, 2014/08/13 20:22:07]

Done.

       metrics::SystemProfileProto* system_profile) OVERRIDE;
 
  protected:
   // Exposed for the sake of mocking in test code.
 
   // Retrieves the set of extensions installed in the current profile.

[Devlin, 2014/08/13 19:50:07]

nit: update comment to say "in the given |profile|"

[jwd, 2014/08/13 20:22:06]

Done.

   // TODO(mvrable): If metrics are ever converted to being per-profile, then

[Devlin, 2014/08/13 19:50:07]

Can we take out the TODO?  Or update it?  (We *are* now returning extensions
installed in a specified profile...)

[jwd, 2014/08/13 20:22:06]

Done.

   // this should be updated to return extensions installed in a specified
   // profile.
-  virtual scoped_ptr<extensions::ExtensionSet> GetInstalledExtensions();
+  virtual scoped_ptr<extensions::ExtensionSet> GetInstalledExtensions(
+      Profile* profile);
 
   // Retrieves the client ID.
   virtual uint64 GetClientID();
 
   // Hashes the extension extension ID using the provided client key (which
   // must be less than kExtensionListClientKeys) and to produce an output value
   // between 0 and kExtensionListBuckets-1.
   static int HashExtension(const std::string& extension_id, uint32 client_key);
 
  private:
   // Returns the profile for which extensions will be gathered.  Once a
   // suitable profile has been found, future calls will continue to return the
   // same value so that reported extensions are consistent.
   Profile* GetMetricsProfile();
 
+  // Writes whether any loaded profiles have extensions not from the webstore.
+  void ProvideOffStoreMetric(metrics::SystemProfileProto* system_profile);
+
+  // Writes the hashed list of installed extensions into the specified
+  // SystemProfileProto object.
+  void ProvideOccupiedBucketMetric(metrics::SystemProfileProto* system_profile);
+
   // The MetricsStateManager from which the client ID is obtained.
   metrics::MetricsStateManager* metrics_state_manager_;
 
-  // The profile for which extensions are gathered.  Once a profile is found
-  // its value is cached here so that GetMetricsProfile() can return a
-  // consistent value.
+  // The profile for which extensions are gathered for the occupied bucket
+  // metric. Once a profile is found its value is cached here so that
+  // GetMetricsProfile() can return a consistent value.
   Profile* cached_profile_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionsMetricsProvider);
 };
 
 #endif  // CHROME_BROWSER_METRICS_EXTENSIONS_METRICS_PROVIDER_H_