Issue 464413002: Expose Value::IsMap, IsSet, IsWeakMap, IsWeakSet in V8 API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464413002: Expose Value::IsMap, IsSet, IsWeakMap, IsWeakSet in V8 API. (Closed)

Created:
6 years, 4 months ago by aandrey

Modified:
6 years, 4 months ago

Reviewers:
Sven Panne, Yang

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Expose Value::IsMap, IsSet, IsWeakMap, IsWeakSet in V8 API. These checks will be needed for DevTools. R=yangguo@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23338

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -46 lines)			Patch
M	include/v8.h	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/api.cc	View	3 chunks	+20 lines, -46 lines	0 comments	Download
M	src/heap/heap.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

On 2014/08/13 16:34:16, aandrey wrote: LGTM, but please land this after the 3.29 branch.

6 years, 4 months ago (2014-08-14 07:30:16 UTC) #2

Yang

On 2014/08/14 07:30:16, Yang wrote: > On 2014/08/13 16:34:16, aandrey wrote: > > LGTM, but ...

6 years, 4 months ago (2014-08-21 06:08:39 UTC) #3

aandrey

6 years, 4 months ago (2014-08-25 08:56:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 23338 (presubmit successful).