Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: net/quic/quic_client_session.cc

Issue 464363005: Add new histograms to confirm that PINGs are outstanding when a QUIC connection times out with open… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session.cc
diff --git a/net/quic/quic_client_session.cc b/net/quic/quic_client_session.cc
index c6699f189bace3a856695447723baebb27611843..91eb2ea2e53280811d5a08801105f3887556074f 100644
--- a/net/quic/quic_client_session.cc
+++ b/net/quic/quic_client_session.cc
@@ -602,7 +602,19 @@ void QuicClientSession::OnConnectionClosed(QuicErrorCode error,
UMA_HISTOGRAM_COUNTS(
"Net.QuicSession.ConnectionClose.NumOpenStreams.TimedOut",
GetNumOpenStreams());
- if (!IsCryptoHandshakeConfirmed()) {
+ if (IsCryptoHandshakeConfirmed()) {
+ if (GetNumOpenStreams() > 0) {
+ UMA_HISTOGRAM_BOOLEAN(
+ "Net.QuicSession.TimedOutWithOpenStreams.HasUnackedPackets",
+ connection()->sent_packet_manager().HasUnackedPackets());
+ UMA_HISTOGRAM_COUNTS(
+ "Net.QuicSession.TimedOutWithOpenStreams.ConsecutiveRTOCount",
+ connection()->sent_packet_manager().consecutive_rto_count());
+ UMA_HISTOGRAM_COUNTS(
+ "Net.QuicSession.TimedOutWithOpenStreams.ConsecutiveTLPCount",
+ connection()->sent_packet_manager().consecutive_tlp_count());
+ }
+ } else {
UMA_HISTOGRAM_COUNTS(
"Net.QuicSession.ConnectionClose.NumOpenStreams.HandshakeTimedOut",
GetNumOpenStreams());
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698