media/video/capture/mac/video_capture_device_mac.mm - Issue 464363003: Mac QTKit Video Capture: Run QTCaptureSession teardown in UI thread, clean up -stopCapture use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/mac/video_capture_device_mac.mm

Issue 464363003: Mac QTKit Video Capture: Run QTCaptureSession teardown in UI thread, clean up -stopCapture use. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: shess@ comments on -stopCaptureOnUIThread: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/video/capture/mac/platform_video_capturing_mac.h ('k') | media/video/capture/mac/video_capture_device_qtkit_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/video/capture/mac/video_capture_device_mac.mm

diff --git a/media/video/capture/mac/video_capture_device_mac.mm b/media/video/capture/mac/video_capture_device_mac.mm

index 2c1943b0b9a6bb51885b3d0dfe16463b8765a78d..66019b7f6477c285ef05a7070c4e7101637e5461 100644

--- a/media/video/capture/mac/video_capture_device_mac.mm

+++ b/media/video/capture/mac/video_capture_device_mac.mm

@@ -440,7 +440,6 @@ void VideoCaptureDeviceMac::AllocateAndStart(

void VideoCaptureDeviceMac::StopAndDeAllocate() {

DCHECK(task_runner_->BelongsToCurrentThread());

DCHECK(state_ == kCapturing || state_ == kError) << state_;

- [capture_device_ stopCapture];

[capture_device_ setCaptureDevice:nil];

[capture_device_ setFrameReceiver:nil];